Add support for generating enum pages for the manual#21469
Open
kocsismate wants to merge 1 commit intophp:PHP-8.5from
Open
Add support for generating enum pages for the manual#21469kocsismate wants to merge 1 commit intophp:PHP-8.5from
kocsismate wants to merge 1 commit intophp:PHP-8.5from
Conversation
Member
|
I'm not sure I'm qualified to review the doc-generation parts of the gen_stub script, deferring to @Girgias for that |
Member
Author
No, I intentionally targeted 8.5 because that's the version which is being synchronized with the manual. |
Girgias
reviewed
Mar 19, 2026
Comment on lines
+948
to
+957
| class EnumCaseName { | ||
| public /* readonly */ Name $enum; | ||
| public /* readonly */ string $case; | ||
|
|
||
| public function __construct(Name $enum, string $case) | ||
| { | ||
| $this->enum = $enum; | ||
| $this->case = $case; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Why do you need this? I don't understand why the enum case needs to know about the name of the enum it's part of?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I intentionally omit the usage of the
enumitemdescriptionelement, and I generate links instead based on php/phd#180 (comment).