Skip to content

doc: optimize English text for better translation in vector search overview#22923

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:release-8.5from
yahonda:fix-vector-search-storage-text-en
May 27, 2026
Merged

doc: optimize English text for better translation in vector search overview#22923
ti-chi-bot[bot] merged 2 commits into
pingcap:release-8.5from
yahonda:fix-vector-search-storage-text-en

Conversation

@yahonda
Copy link
Copy Markdown
Member

@yahonda yahonda commented May 25, 2026

This PR optimizes the English text in ai/concepts/vector-search-overview.md to be more natural and to ensure better automatic translation into Japanese. Specifically, it changes 'You can choose any of the following ways for storage:' to 'You can store your data in either of the following ways:', which leads to a more natural Japanese translation.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vector search overview documentation to clarify data storage options. The reviewer suggested a further refinement to improve conciseness by removing unnecessary phrasing in the description of vector embeddings, aligning with the style guide's recommendation to avoid wordiness.

Comment thread ai/concepts/vector-search-overview.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@yahonda
Copy link
Copy Markdown
Member Author

yahonda commented May 25, 2026

The failure in the check-keywords job appears to be unrelated to the changes in this PR, as this PR only modifies ai/concepts/vector-search-overview.md and does not touch keywords.md or any related keyword definitions.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 27, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 27, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-05-27 02:09:26.212591597 +0000 UTC m=+404436.182756655: ☑️ agreed by qiancai.

@qiancai qiancai added translation/no-need No need to translate this PR. needs-cherry-pick-master Should cherry pick this PR to master branch. and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 27, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label May 27, 2026
@qiancai qiancai self-assigned this May 27, 2026
@qiancai qiancai added the lgtm label May 27, 2026
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented May 27, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label May 27, 2026
@ti-chi-bot ti-chi-bot Bot merged commit dbe5a0c into pingcap:release-8.5 May 27, 2026
11 of 12 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch master: #22948.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants