-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Description
"It was brought to my attention that this pattern has a precedent:
Prebid.js/modules/pubxaiRtdProvider.js
Lines 7 to 11 in 20d2c93
| /** | |
| * This RTD module has a dependency on the priceFloors module. | |
| * We utilize the createFloorsDataForAuction function from the priceFloors module to incorporate price floors data into the current auction. | |
| */ | |
| import { createFloorsDataForAuction } from './priceFloors.js'; // eslint-disable-line prebid/validate-imports |
Same issue applies there; it makes the module larger and more brittle. However it can (and hopefully does) work, as long as the floors logic doesn't change.
It may be worth updating the floors module to support this use case - allow RTD providers to set floors data.
In the meanwhile, my recommendation remains to remove the dependency on the internals of floors, and update this to just set config for it; but since we have a precedent I'm OK with moving this forward as it is."
Originally posted by @dgirardi in #12732 (comment)
also in #14104 there was additional discussion. It seems Pubmatic team has a fix planned
Metadata
Metadata
Assignees
Labels
Type
Projects
Status