Upgrade to React v19 #73
Merged
+14,556
−10,193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
danielguillan
force-pushed
the
danielguillan/upgrade-primer-brand-and-react-v19+
branch
from
231d77b to
d4dadd3
Compare
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the codebase to support React 19 while maintaining backwards compatibility with React 18. The changes include dependency updates, TypeScript type fixes for stricter React 19 types, and component API migrations to align with updated Primer library versions.
- Updated React and TypeScript types to v19
- Upgraded
@primer/react-brandfrom v0.54.0 to v0.60.1, requiring migration fromLabeltoTokencomponent - Added explicit
asprops to polymorphic Primer components for React 19 type compatibility - Added ESLint dependencies that are no longer transitively hoisted
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/theme/package.json | Updated dependencies: removed React from dependencies (keeping in peerDependencies), upgraded framer-motion and react-focus-on, updated @types/react and @types/react-dom to v19, removed overrides section |
| packages/site/package.json | Upgraded React to v19.2.0, @primer/react-brand to v0.60.1, and added @types/react and @types/react-dom v19 as dev dependencies |
| package.json | Upgraded @primer/react-brand to v0.60.1 and added previously transitive ESLint dependencies (@typescript-eslint/eslint-plugin, eslint-plugin-prettier) |
| packages/theme/components/layout/related-content-links/getRelatedPages.tsx | Fixed TypeScript error by adding explicit type assertion for React element props to safely access children property |
| packages/theme/components/layout/code-block/ReactCodeBlock.tsx | Fixed TypeScript error in helper function with explicit type assertion for React element props |
| packages/theme/components/layout/nav-drawer/NavDrawer.tsx | Added explicit as="button" prop to IconButton for React 19 polymorphic component typing |
| packages/theme/components/layout/header/Header.tsx | Added explicit as="button" prop to all IconButton instances for React 19 compatibility |
| packages/theme/components/layout/global-search/GlobalSearch.tsx | Added explicit as="input" prop to TextInput for React 19 polymorphic component typing |
| packages/theme/components/layout/article/ReadinessLabel.tsx | Migrated from Label to Token component API, adding aria-hidden to icon for proper accessibility |
| packages/theme/components/layout/article/ReadinessLabel.module.css | Removed CSS properties now handled by Token component, added !important to color override |
| packages/theme/components/layout/article/AccessibilityLabel.tsx | Migrated from Label to Token component API, adding aria-hidden to icon for proper accessibility |
| packages/theme/components/layout/article/AccessibilityLabel.module.css | Removed CSS properties now handled by Token component, added !important to color override |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
danielguillan
force-pushed
the
danielguillan/upgrade-primer-brand-and-react-v19+
branch
from
c1e7bef to
e064c35
Compare
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
rezrah
reviewed
Dec 4, 2025
| 'doctocat-nextjs-site': minor | ||
| --- | ||
|
|
||
| Add React 19 support |
Collaborator
There was a problem hiding this comment.
@danielguillan do you know if this is still backwards compatible with React 18? I think it's fine if it's not, but we should make that clear here that it's a breaking change.
Contributor
Author
There was a problem hiding this comment.
Yes, the update is backward compatible with React 18. But since it updates @primer/react to version 38, there may be potential incompatibilities for users relying on features from versions earlier than 38 (e.g., Box component, sx prop). I have noted this in the changeset.
rezrah
reviewed
Dec 4, 2025
rezrah
reviewed
Dec 4, 2025
rezrah
reviewed
Dec 4, 2025
| 'use client' | ||
| import React from 'react' | ||
| import {Label} from '@primer/react' | ||
| import {Token} from '@primer/react' |
rezrah
reviewed
Dec 4, 2025
rezrah
approved these changes
Dec 4, 2025
Collaborator
rezrah
left a comment
rezrah
left a comment
There was a problem hiding this comment.
Minor feedback. ✅ to unblock. Thanks @danielguillan ⭐
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
danielguillan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/github/primer/issues/6134
Upgrades
doctocat-nextjsto support React 19 and updates Primer Brand tov0.60.0. The changes ensure static builds work correctly with React 19 while maintaining backwards compatibility with React 18.Key Changes
package-lock.jsonto resolve version mismatch issues during SSR@primer/react-brandfrom an earlier version to v0.60.1AccessibilityLabel,ReadinessLabel,ReactCodeBlock,NavDrawer,getRelatedPages)eslint-plugin-prettierand@typescript-eslint/eslint-pluginas direct dependencies (previously transitive, no longer hoisted after lock file regeneration)