Skip to content

Commit 8f1056c

Browse files
committed
PR feedback
1 parent e88d66f commit 8f1056c

18 files changed

+86824
-86798
lines changed

Include/internal/pycore_ast.h

Lines changed: 948 additions & 948 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Include/internal/pycore_ast_state.h

Lines changed: 272 additions & 272 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Include/internal/pycore_opcode_metadata.h

Lines changed: 2139 additions & 2139 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Include/internal/pycore_uop_ids.h

Lines changed: 1303 additions & 1303 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Include/internal/pycore_uop_metadata.h

Lines changed: 6309 additions & 6309 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Include/opcode_ids.h

Lines changed: 261 additions & 261 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Lib/_opcode_metadata.py

Lines changed: 375 additions & 375 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Lib/test/list_tests.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,30 @@ def infinite_gen():
228228
a[::-2] = infinite_gen()
229229
self.assertEqual(a, self.type2test(range(6)))
230230

231+
# Explicit start and stop with infinite iterator
232+
a = self.type2test(range(10))
233+
with self.assertRaises(ValueError):
234+
a[1:8:2] = infinite_gen()
235+
self.assertEqual(a, self.type2test(range(10)))
236+
237+
# Explicit start only
238+
a = self.type2test(range(10))
239+
with self.assertRaises(ValueError):
240+
a[2::3] = infinite_gen()
241+
self.assertEqual(a, self.type2test(range(10)))
242+
243+
# Explicit stop only
244+
a = self.type2test(range(10))
245+
with self.assertRaises(ValueError):
246+
a[:7:2] = infinite_gen()
247+
self.assertEqual(a, self.type2test(range(10)))
248+
249+
# Negative step with explicit start and stop
250+
a = self.type2test(range(10))
251+
with self.assertRaises(ValueError):
252+
a[8:1:-2] = infinite_gen()
253+
self.assertEqual(a, self.type2test(range(10)))
254+
231255
def test_extended_slice_assign_iterator(self):
232256
# Assigning a finite iterator with the correct length to an
233257
# extended slice should work.

0 commit comments

Comments
 (0)