fix: partially revert dbec32c

This fixes a fatal error condition that occurs in some cases because
Symfony's Question::getQuestion() method was not compatible with
StarterKitQuestion::getQuestion(). Rather than attempt to specify the
full Symfony Question interface as the StarterKitQuestion interface,
this simply ignores the PHPStan errors in the QuestionTestCase test
class.

Author: ramsey

src/LibraryStarterKit/Console/Question/StarterKitQuestion.php

@@ -12,63 +12,10 @@
 namespace Ramsey\Dev\LibraryStarterKit\Console\Question;
 
 use Ramsey\Dev\LibraryStarterKit\Answers;
-use Symfony\Component\Console\Question\Question;
 
-/**
- * A starter kit question
- *
- * Except {@see self::getAnswers()} and {@see self::getName()}, all methods on
- * this interface are from {@see \Symfony\Component\Console\Question\Question}.
- */
 interface StarterKitQuestion
 {
     public function getAnswers(): Answers;
 
     public function getName(): string;
-
-    public function getQuestion(): string;
-
-    public function getDefault(): string | bool | int | float | null;
-
-    public function isMultiline(): bool;
-
-    public function setMultiline(bool $multiline): Question;
-
-    public function isHidden(): bool;
-
-    public function setHidden(bool $hidden): Question;
-
-    public function isHiddenFallback(): bool;
-
-    public function setHiddenFallback(bool $fallback): Question;
-
-    /**
-     * @return iterable<string> | null
-     */
-    public function getAutocompleterValues(): ?iterable;
-
-    /**
-     * @param iterable<string> | null $values
-     */
-    public function setAutocompleterValues(?iterable $values): Question;
-
-    public function getAutocompleterCallback(): ?callable;
-
-    public function setAutocompleterCallback(?callable $callback): Question;
-
-    public function setValidator(?callable $validator): Question;
-
-    public function getValidator(): ?callable;
-
-    public function setMaxAttempts(?int $attempts): Question;
-
-    public function getMaxAttempts(): ?int;
-
-    public function setNormalizer(callable $normalizer): Question;
-
-    public function getNormalizer(): ?callable;
-
-    public function isTrimmable(): bool;
-
-    public function setTrimmable(bool $trimmable): Question;
 }

tests/LibraryStarterKit/Console/Question/QuestionTestCase.php

@@ -6,11 +6,12 @@
 
 use Ramsey\Dev\LibraryStarterKit\Console\Question\StarterKitQuestion;
 use Ramsey\Test\Dev\LibraryStarterKit\TestCase;
+use Symfony\Component\Console\Question\Question;
 
 abstract class QuestionTestCase extends TestCase
 {
     /**
-     * @return class-string<StarterKitQuestion>
+     * @return class-string<StarterKitQuestion & Question>
      */
     abstract protected function getTestClass(): string;
 
@@ -26,6 +27,8 @@ protected function getQuestionDefault(): mixed
     public function testGetName(): void
     {
         $questionClass = $this->getTestClass();
+
+        /** @phpstan-ignore-next-line */
         $question = new $questionClass($this->answers);
 
         $this->assertSame($this->getQuestionName(), $question->getName());
@@ -34,6 +37,8 @@ public function testGetName(): void
     public function testGetQuestion(): void
     {
         $questionClass = $this->getTestClass();
+
+        /** @phpstan-ignore-next-line */
         $question = new $questionClass($this->answers);
 
         $this->assertSame($this->getQuestionText(), $question->getQuestion());
@@ -42,6 +47,8 @@ public function testGetQuestion(): void
     public function testGetAnswers(): void
     {
         $questionClass = $this->getTestClass();
+
+        /** @phpstan-ignore-next-line */
         $question = new $questionClass($this->answers);
 
         $this->assertSame($this->answers, $question->getAnswers());
@@ -50,6 +57,8 @@ public function testGetAnswers(): void
     public function testGetDefault(): void
     {
         $questionClass = $this->getTestClass();
+
+        /** @phpstan-ignore-next-line */
         $question = new $questionClass($this->answers);
 
         $this->assertSame($this->getQuestionDefault(), $question->getDefault());
@@ -60,6 +69,8 @@ public function testGetDefaultWhenAnswerAlreadySet(): void
         $this->answers->{$this->getQuestionName()} = 'foobar';
 
         $questionClass = $this->getTestClass();
+
+        /** @phpstan-ignore-next-line */
         $question = new $questionClass($this->answers);
 
         $this->assertSame('foobar', $question->getDefault());