chore: address static analysis issues

Author: ramsey

src/LibraryStarterKit/Setup.php

@@ -122,8 +122,6 @@ public function getVerbosity(): int
      * Returns an instance used for executing a system command
      *
      * @param string[] $command
-     *
-     * @phpstan-ignore-next-line
      */
     public function getProcess(array $command): Process
     {

src/LibraryStarterKit/Task/Builder/RenameTemplates.php

@@ -41,7 +41,6 @@ public function build(): void
     {
         $this->getConsole()->section('Renaming template files');
 
-        /** @var SplFileInfo $template */
         foreach ($this->getTemplatesFinder() as $template) {
             $this->removeTemplateExtension($template);
         }

src/LibraryStarterKit/Task/Builder/UpdateComposerJson.php

@@ -24,7 +24,6 @@
 
 use Ramsey\Dev\LibraryStarterKit\Task\Builder;
 use RuntimeException;
-use Symfony\Component\Finder\SplFileInfo;
 
 use function in_array;
 use function json_decode;
@@ -37,6 +36,10 @@
 
 /**
  * Updates values in the composer.json file
+ *
+ * @psalm-type ComposerAuthorType = array{name: string, email?: string | null, homepage?: string | null}
+ * @psalm-type ComposerAutoloadType = array{psr-4?: array<string, string>}
+ * @psalm-type ComposerType = array{name: string, description: string, type: string, keywords: string[], license: string | null, authors: ComposerAuthorType[], require?: array<string, string>, require-dev?: array<string, string>, autoload?: ComposerAutoloadType, autoload-dev?: ComposerAutoloadType, scripts?: array<string, string | string[]>, scripts-descriptions?: array<string, string>, suggest?: array<string, string>}
  */
 class UpdateComposerJson extends Builder
 {
@@ -63,7 +66,7 @@ public function build(): void
         $this->getConsole()->section('Updating composer.json');
 
         /**
-         * @var array<string, mixed>|null $composer
+         * @psalm-var ComposerType|null $composer
          */
         $composer = json_decode($this->getComposerContents(), true);
         if ($composer === null) {
@@ -122,7 +125,6 @@ private function getComposerContents(): string
 
         $composerContents = null;
 
-        /** @var SplFileInfo $file */
         foreach ($finder as $file) {
             $composerContents = $file->getContents();
 
@@ -137,12 +139,12 @@ private function getComposerContents(): string
     }
 
     /**
-     * @param array<string, mixed> $composer
+     * @psalm-param ComposerType $composer
      */
     private function buildAuthors(array &$composer): void
     {
-        $author = [];
-        $author['name'] = $this->getAnswers()->authorName;
+        /** @var ComposerAuthorType $author */
+        $author = ['name' => $this->getAnswers()->authorName];
 
         if (trim((string) $this->getAnswers()->authorEmail) !== '') {
             $author['email'] = $this->getAnswers()->authorEmail;
@@ -156,73 +158,61 @@ private function buildAuthors(array &$composer): void
     }
 
     /**
-     * @param array<string, mixed> $composer
+     * @psalm-param ComposerType $composer
      */
     private function buildRequire(array &$composer): void
     {
         if (!isset($composer['require'])) {
             return;
         }
 
-        /** @var array<string, string> $require */
-        $require = $composer['require'];
-
         $composer['require'] = $this->filterPropertiesByWhitelist(
-            $require,
+            $composer['require'],
             self::WHITELIST_REQUIRE,
         );
     }
 
     /**
-     * @param array<string, mixed> $composer
+     * @psalm-param ComposerType $composer
      */
     private function buildRequireDev(array &$composer): void
     {
         if (!isset($composer['require-dev'])) {
             return;
         }
 
-        /** @var array<string, string> $requireDev */
-        $requireDev = $composer['require-dev'];
-
         $composer['require-dev'] = $this->filterPropertiesByWhitelist(
-            $requireDev,
+            $composer['require-dev'],
             self::WHITELIST_REQUIRE_DEV,
         );
     }
 
     /**
-     * @param array<string, mixed> $composer
+     * @psalm-param ComposerType $composer
      */
     private function buildAutoload(array &$composer): void
     {
         if (!isset($composer['autoload']['psr-4'])) {
             return;
         }
 
-        /** @var array<string, string> $autoload */
-        $autoload = $composer['autoload']['psr-4'];
-
         $composer['autoload']['psr-4'] = $this->filterPropertiesByWhitelist(
-            $autoload,
+            $composer['autoload']['psr-4'],
             self::WHITELIST_AUTOLOAD,
         );
     }
 
     /**
-     * @param array<string, mixed> $composer
+     * @psalm-param ComposerType $composer
      */
     private function buildAutoloadDev(array &$composer): void
     {
         if (!isset($composer['autoload-dev']['psr-4'])) {
             return;
         }
 
-        /** @var array<string, string> $autoloadDev */
-        $autoloadDev = $composer['autoload-dev']['psr-4'];
-
         $composer['autoload-dev']['psr-4'] = $this->filterPropertiesByWhitelist(
-            $autoloadDev,
+            $composer['autoload-dev']['psr-4'],
             self::WHITELIST_AUTOLOAD_DEV,
         );
     }

src/LibraryStarterKit/Task/Builder/UpdateNamespace.php

@@ -95,7 +95,6 @@ private function getSourceFiles(): array
             ->depth('== 0')
             ->name('composer.json');
 
-        /** @var SplFileInfo $file */
         foreach ($composerFinder as $file) {
             $files[] = $file;
 

src/LibraryStarterKit/Task/Builder/UpdateReadme.php

@@ -24,7 +24,6 @@
 
 use Ramsey\Dev\LibraryStarterKit\Task\Builder;
 use RuntimeException;
-use Symfony\Component\Finder\SplFileInfo;
 
 use function array_keys;
 use function array_values;
@@ -81,7 +80,6 @@ private function getReadmeContents(): string
 
         $readmeContents = null;
 
-        /** @var SplFileInfo $file */
         foreach ($finder as $file) {
             $readmeContents = $file->getContents();
 

src/LibraryStarterKit/Task/Builder/UpdateSourceFileHeaders.php

@@ -52,7 +52,6 @@ public function build(): void
         $headerLines = array_filter($headerLines);
         $newFileHeader = implode("\n", $headerLines);
 
-        /** @var SplFileInfo $file */
         foreach ($this->getSourceFilesFinder() as $file) {
             $this->replaceSourceFileHeader($file, $newFileHeader);
         }

src/LibraryStarterKit/Wizard.php

@@ -261,7 +261,10 @@ public static function newApplication(): Application
 
     public static function start(Event $event): void
     {
-        $appPath = dirname((string) $event->getComposer()->getConfig()->get('vendor-dir'));
+        /** @var string $vendorDir */
+        $vendorDir = $event->getComposer()->getConfig()->get('vendor-dir');
+
+        $appPath = dirname($vendorDir);
 
         $projectName = strtolower(basename((string) realpath($appPath)));
         $projectName = (string) preg_replace('/[^a-z0-9]/', '-', $projectName);

tests/LibraryStarterKit/Console/Question/QuestionTestCase.php

@@ -4,10 +4,15 @@
 
 namespace Ramsey\Test\Dev\LibraryStarterKit\Console\Question;
 
+use Ramsey\Dev\LibraryStarterKit\Console\Question\StarterKitQuestion;
 use Ramsey\Test\Dev\LibraryStarterKit\TestCase;
+use Symfony\Component\Console\Question\Question;
 
 abstract class QuestionTestCase extends TestCase
 {
+    /**
+     * @return class-string<Question & StarterKitQuestion>
+     */
     abstract protected function getTestClass(): string;
 
     abstract protected function getQuestionName(): string;

tests/LibraryStarterKit/WindowsSafeTextDriver.php

@@ -16,6 +16,8 @@
 class WindowsSafeTextDriver implements Driver
 {
     /**
+     * @param string $data
+     *
      * @inheritDoc
      */
     public function serialize($data): string
@@ -32,6 +34,9 @@ public function extension(): string
     }
 
     /**
+     * @param string $expected
+     * @param string $actual
+     *
      * @inheritDoc
      */
     public function match($expected, $actual): void