drivers: media: i2c: imx219: Fix for imx219_get_binning()#7392
drivers: media: i2c: imx219: Fix for imx219_get_binning()#7392njhollinghurst wants to merge 1 commit into
Conversation
|
Candidate fix for #7391 |
|
There remains some redundancy in
but perhaps that's not urgent to fix. |
Fixes: 5eb74d4 ("Remove enum binning_mode") which mixed two different interpretations of "bin_h", "bin_v" (as binning factors and as binning modes), and broke binning. In this version they are factors; the return value is the selected binning mode (which also depends on the sensor mode). Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>
dc39206 to
5fd9c40
Compare
|
Do just check the patches off mainline for duplication. Sakari's patchset at https://lore.kernel.org/linux-media/20260408153939.969381-1-sakari.ailus@linux.intel.com/ is also messing with imx219, and I'm reviewing those patches at the moment. |
|
Hmm. The above is the minimal fix to unbreak what we have now. The thing we need to bring in that's absent from mainline, is the sensor-mode-dependent binning method, from 82ffe96 I'll have another go... |
|
Upstream, Jai has increased the LLP slightly, and that has fixed the need for different binning modes. Those should have been in 6.15 and above, so I'm not sure there is a need any longer. |
|
Will start again by reverting downstream changes... |
Fixes 5eb74d4 ("Remove enum binning_mode")
which mixed two different interpretations of "bin_h", "bin_v" (as binning factors and as binning modes), and broke binning.
In this version they are factors; the return value is the selected binning mode (which also depends on the sensor mode).