Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 2 people

networkstats/plugin/CMakeLists.txt

@@ -116,7 +116,7 @@ install(
 set(PLUGIN_NETWORKCONNECTIONSTATS_AUTOSTART "false" CACHE STRING "Automatically start the plugin")
 set(PLUGIN_NETWORKCONNECTIONSTATS_OUTOFPROCESS "true" CACHE STRING "Run plugin out-of-process")
 set(PLUGIN_NETWORKCONNECTIONSTATS_STARTUPORDER "50" CACHE STRING "Plugin startup order")
-set(PLUGIN_NETWORKCONNECTIONSTATS_REPORTING_INTERVAL "90" CACHE STRING "Reporting interval in seconds (default: 90 seconds)")
+set(PLUGIN_NETWORKCONNECTIONSTATS_REPORTING_INTERVAL "600" CACHE STRING "Reporting interval in seconds (default: 600 seconds)")
 set(PLUGIN_NETWORKCONNECTIONSTATS_PROVIDER_TYPE "comrpc" CACHE STRING "Network data provider type: 'comrpc' or 'jsonrpc' (default: comrpc)")
 
 # Install configuration

networkstats/plugin/NetworkConnectionStatsImplementation.cpp

@@ -31,7 +31,7 @@ using namespace NetworkConnectionStatsLogger;
 namespace WPEFramework {
 namespace Plugin {
 
-    SERVICE_REGISTRATION(NetworkConnectionStatsImplementation, 1, 0);
+    SERVICE_REGISTRATION(NetworkConnectionStatsImplementation, API_VERSION_NUMBER_MAJOR, API_VERSION_NUMBER_MINOR, API_VERSION_NUMBER_PATCH);
 
     NetworkConnectionStatsImplementation::NetworkConnectionStatsImplementation()
         : _adminLock()
@@ -52,8 +52,8 @@ namespace Plugin {
         , m_subsIPAddrChange(false)
     {
 
-        NSLOG_INFO("NetworkConnectionStatsImplemen  tation Constructor");
-        /* Set NetworkManager Out-Process name to be NWMgrPlugin */
+        NSLOG_INFO("NetworkConnectionStatsImplementation Constructor");
+        /* Set NetworkManager Out-Process name to be "NetworkConnectionStats" */
         Core::ProcessInfo().Name("NetworkConnectionStats");
         NSLOG_INFO((_T("NetworkConnectionStats Out-Of-Process Instantiation; SHA: " _T(EXPAND_AND_QUOTE(PLUGIN_BUILD_REFERENCE)))));
 #if USE_TELEMETRY
@@ -205,6 +205,9 @@ namespace Plugin {
                 auto factoryType = NetworkDataProviderFactory::ParseProviderType(providerType);
                 std::string typeName = NetworkDataProviderFactory::GetProviderTypeName(factoryType);
                 NSLOG_ERROR("Failed to initialize %s provider", typeName.c_str());
+                // Clean up the partially initialized provider to prevent leaks and later accidental use
+                delete m_provider;
+                m_provider = nullptr;
                 result = Core::ERROR_GENERAL;
             }
         }
@@ -292,7 +295,7 @@ namespace Plugin {
 
     void NetworkConnectionStatsImplementation::logTelemetry(const std::string& eventName, const std::string& message)
     {
-        NSLOG_INFO("NS_T2: %s:%s", eventName.c_str(), message.c_str());
+        //NSLOG_INFO("NS_T2: %s:%s", eventName.c_str(), message.c_str());
 #if USE_TELEMETRY
         T2ERROR t2error = t2_event_s(eventName.c_str(), (char*)message.c_str());
         if (t2error != T2ERROR_SUCCESS) {
@@ -383,7 +386,7 @@ namespace Plugin {
             std::string packetLoss = m_provider->getPacketLoss();
             std::string avgRtt = m_provider->getAvgRtt();
             if (success) {
-                NSLOG_INFO("IPv4 gateway ping - Loss: %s%%, RTT: %sms",
+                NSLOG_INFO("IPv4 gateway ping Loss: %s%%, RTT: %s",
                        packetLoss.c_str(), avgRtt.c_str());
 
                 logTelemetry("IPv4_Gateway_Packet_Loss", packetLoss);
@@ -407,7 +410,7 @@ namespace Plugin {
             std::string packetLoss = m_provider->getPacketLoss();
             std::string avgRtt = m_provider->getAvgRtt();
             if (success) {
-                NSLOG_INFO("IPv6 gateway ping - Loss: %s%%, RTT: %sms",
+                NSLOG_INFO("IPv6 gateway ping Loss: %s%%, RTT: %s",
                        packetLoss.c_str(), avgRtt.c_str());
 
                 logTelemetry("IPv6_Gateway_Packet_Loss", packetLoss);