feat(ios): allow inline calendar to fill available width#1024
Closed
Scr3nt wants to merge 3 commits intoreact-native-datetimepicker:masterfrom
Closed
feat(ios): allow inline calendar to fill available width#1024Scr3nt wants to merge 3 commits intoreact-native-datetimepicker:masterfrom
Scr3nt wants to merge 3 commits intoreact-native-datetimepicker:masterfrom
Conversation
Collaborator
|
This would be great to land, some suggestions:
If you don't have time to test both paths I would suggest dropping the old arch changes to minimize the surface area here, since this branch is considered frozen these days |
Member
|
Hello and thanks for the PR, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR made with Cursor AI
Motivation
Fixes #1014
This PR resolves layout issues with the iOS DateTimePicker component when using
display="inline"(calendar mode):Implementation
Width Fix
Updated the Yoga layout measurement functions to properly respect layout constraints:
RNDateTimePickerShadowView.m): ModifiedRNDateTimePickerShadowViewMeasureto use full available width inYGMeasureModeAtMostfor inline/calendar displayRNDateTimePickerComponentView.mm): Set larger default width (375pt) for inline style which gets properly constrained by parentRNDateTimePicker.m): Updated to suggest 375pt width for inline display to help with layout calculationsKey Changes:
ios/RNDateTimePicker.m: UpdatedintrinsicContentSizeto suggest appropriate dimensions for inline styleios/RNDateTimePickerShadowView.m: Enhanced measure function with proper width/height constraint handlingios/fabric/RNDateTimePickerComponentView.mm: UpdatedupdateMeasurementsfor both width and heightImpact Areas
display="inline"mode (calendar view)Test Plan
Steps to Reproduce
<View style={{ width: 320 }}>
Compatibility
Note: This is an iOS-specific fix. Android does not have these UIKit warnings.
Checklist
README.mdexample/App.js)