Invisible columns snapshotting fail

[sandaru1]

Summary

When a table has a INVISIBLE columns, Readyset tries to snapshot that table and it fails and Readyset goes into an infinite loop.

Expected behavior

Tables with INVISIBLE columns should be excluded from the supported tables list.

Actual behavior

Infinite loop when snapshotting.

Steps to reproduce

Create a table with an INVISIBLE column and add data without specifying the primary key.

Run Readyset against the test database.

ReadySet version

82db704f98596e9b49542a0e5a862162bd2bae61

Upstream DB type and version

MySQL 8.3.0

Logs

2024-10-17T13:48:05.559800Z ERROR taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: error=Failed to manipulate table testdb.a: wrong number of columns specified: expected 2, got 1
2024-10-17T13:48:05.559810Z ERROR taking database snapshot: replicators::mysql_connector::snapshot: Replication failed, retrying table=`testdb`.`a` error=Failed to manipulate table testdb.a: wrong number of columns specified: expected 2, got 1
2024-10-17T13:48:05.559814Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Acquiring read lock
2024-10-17T13:48:05.560172Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Snapshotting table
2024-10-17T13:48:05.560387Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Read lock released
2024-10-17T13:48:05.561206Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Snapshotting started rows=1
2024-10-17T13:48:05.563709Z ERROR taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: error=Failed to manipulate table testdb.a: wrong number of columns specified: expected 2, got 1
2024-10-17T13:48:05.563718Z ERROR taking database snapshot: replicators::mysql_connector::snapshot: Replication failed, retrying table=`testdb`.`a` error=Failed to manipulate table testdb.a: wrong number of columns specified: expected 2, got 1
2024-10-17T13:48:05.563722Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Acquiring read lock
2024-10-17T13:48:05.563930Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Snapshotting table
2024-10-17T13:48:05.564121Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Read lock released
2024-10-17T13:48:05.564694Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Snapshotting started rows=1
2024-10-17T13:48:05.567337Z ERROR taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: error=Failed to manipulate table testdb.a: wrong number of columns specified: expected 2, got 1
2024-10-17T13:48:05.567347Z ERROR taking database snapshot: replicators::mysql_connector::snapshot: Replication failed, retrying table=`testdb`.`a` error=Failed to manipulate table testdb.a: wrong number of columns specified: expected 2, got 1
2024-10-17T13:48:05.567353Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Acquiring read lock
2024-10-17T13:48:05.567573Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Snapshotting table
2024-10-17T13:48:05.567769Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Read lock released
2024-10-17T13:48:05.568969Z  INFO taking database snapshot:Snapshotting table{table=`testdb`.`a`}: replicators::mysql_connector::snapshot: Snapshotting started rows=1

[sandaru1]

Another repro:

mysql> CREATE TABLE foo (a INT, b INT INVISIBLE);
Query OK, 0 rows affected (0.02 sec)

mysql> INSERT INTO foo VALUES (42);
Query OK, 1 row affected (0.01 sec)

Then start Readyset:

2025-09-11T22:11:41.742776Z  INFO dataflow_state::persistent_state: Base creating primary index base=readyset.db-noria-foo-0.db index=[0] is_unique=false
2025-09-11T22:11:41.771853Z  INFO taking database snapshot:Snapshotting table{table=`noria`.`foo`}: replicators::mysql_connector::snapshot: Acquiring read lock
2025-09-11T22:11:41.775375Z  INFO taking database snapshot:Snapshotting table{table=`noria`.`foo`}: replicators::mysql_connector::snapshot: Snapshotting table
2025-09-11T22:11:41.780855Z  INFO taking database snapshot:Snapshotting table{table=`noria`.`foo`}: replicators::mysql_connector::snapshot: Read lock released
2025-09-11T22:11:41.785967Z  INFO taking database snapshot:Snapshotting table{table=`noria`.`foo`}: replicators::mysql_connector::snapshot: Snapshotting started approximate_rows=1
2025-09-11T22:11:41.796727Z ERROR taking database snapshot:Snapshotting table{table=`noria`.`foo`}: replicators::mysql_connector::snapshot: error=Failed to manipulate table noria.foo
: wrong number of columns specified: expected 2, got 1
2025-09-11T22:11:41.796844Z ERROR taking database snapshot: replicators::mysql_connector::snapshot: Replication failed, retrying table=`noria`.`foo` error=Failed to manipulate table
noria.foo: wrong number of columns specified: expected 2, got 1

Instead of rejecting the table, let's build an explicit select list for the snapshot query that includes the invisible columns.

[sandaru1]

Report as an error in Core for now.