simplify fallback

Author: bilsen

crates/viewer/re_component_fallbacks/src/component_fallbacks.rs

@@ -63,35 +63,7 @@ pub fn archetype_field_fallbacks(registry: &mut FallbackProviderRegistry) {
     );
     registry.register_component_fallback_provider(
         archetypes::BarChart::descriptor_widths().component,
-        |ctx| {
-            // This fallback is for widths - set all widths to 1.0
-
-            // Try to get the values tensor to determine the length
-            if let Some(((_time, _row_id), tensor)) = ctx
-                .recording()
-                .latest_at_component::<components::TensorData>(
-                    ctx.target_entity_path,
-                    ctx.query,
-                    archetypes::BarChart::descriptor_values().component,
-                )
-                && tensor.is_vector()
-            {
-                let shape = tensor.shape();
-                if let Some(&length) = shape.first() {
-                    // Set all widths to 1.0
-                    let tensor_data = datatypes::TensorData::new(
-                        vec![length],
-                        datatypes::TensorBuffer::F32(vec![1.0; length as usize].into()),
-                    );
-                    return components::TensorData(tensor_data);
-                }
-            }
-
-            // Fallback to empty tensor if we can't determine the values length
-            let tensor_data =
-                datatypes::TensorData::new(vec![0u64], datatypes::TensorBuffer::I64(vec![].into()));
-            components::TensorData(tensor_data)
-        },
+        |_| components::Length::from(1.0),
     );
 
     // GraphNodes

crates/viewer/re_view_bar_chart/src/visualizer_system.rs

@@ -4,13 +4,13 @@ use re_chunk_store::LatestAtQuery;
 use re_entity_db::EntityPath;
 use re_types::{
     archetypes::BarChart,
-    components::{self},
+    components::{self, Length},
     datatypes,
 };
 use re_view::{DataResultQuery as _, RangeResultsExt as _};
 use re_viewer_context::{
     IdentifiedViewSystem, ViewContext, ViewContextCollection, ViewQuery, ViewSystemExecutionError,
-    VisualizerQueryInfo, VisualizerSystem,
+    VisualizerQueryInfo, VisualizerSystem, typed_fallback_for,
 };
 
 #[derive(Default)]
@@ -74,7 +74,11 @@ impl VisualizerSystem for BarChartVisualizerSystem {
                     }
                     widths
                 } else {
-                    vec![1.0_f32; length as usize]
+                    let fallback_width: Length = typed_fallback_for(
+                        &ctx.query_context(data_result, &view_query.latest_at_query()),
+                        BarChart::descriptor_widths().component,
+                    );
+                    vec![fallback_width.0.into(); length as usize]
                 };
                 self.charts.insert(
                     data_result.entity_path.clone(),