From 0a083f70c8c70d627a6e15d185323b26e38add5b Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 25 Feb 2026 16:21:09 +0000 Subject: [PATCH] Enable argoRollouts by default MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Argo Rollouts discovery is safe to enable by default because the code gracefully handles the case when the CRD is not installed — the exception is caught, logged, and discovery continues with other resource types. Changes: - values.yaml: argoRollouts default false -> true - env_vars.py: ARGO_ROLLOUTS default False -> True - runner.yaml: always set ARGO_ROLLOUTS env var (supports explicit opt-out) https://claude.ai/code/session_016YtwFoKAXgZ73VWCD2Jyt1 --- helm/robusta/templates/runner.yaml | 4 +--- helm/robusta/values.yaml | 2 +- src/robusta/core/model/env_vars.py | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/helm/robusta/templates/runner.yaml b/helm/robusta/templates/runner.yaml index b83df3c07..7917121b7 100644 --- a/helm/robusta/templates/runner.yaml +++ b/helm/robusta/templates/runner.yaml @@ -124,10 +124,8 @@ spec: - name: IS_OPENSHIFT value: "True" {{- end }} - {{- if .Values.argoRollouts }} - name: ARGO_ROLLOUTS - value: "True" - {{- end }} + value: {{ ternary "True" "False" .Values.argoRollouts | quote }} {{- if .Values.runner.customCRD }} - name: CUSTOM_CRD value: {{ .Values.runner.customCRD | toJson | squote }} diff --git a/helm/robusta/values.yaml b/helm/robusta/values.yaml index 16a48f1b5..1b2fe3f8e 100644 --- a/helm/robusta/values.yaml +++ b/helm/robusta/values.yaml @@ -106,7 +106,7 @@ enablePrometheusStack: false enabledManagedConfiguration: false enableServiceMonitors: true monitorHelmReleases: true -argoRollouts: false +argoRollouts: true diff --git a/src/robusta/core/model/env_vars.py b/src/robusta/core/model/env_vars.py index 8c45ff7a7..870bb65f8 100644 --- a/src/robusta/core/model/env_vars.py +++ b/src/robusta/core/model/env_vars.py @@ -122,7 +122,7 @@ def load_bool(env_var, default: bool): RUN_AS_SUBPROCESS = load_bool("RUN_AS_SUBPROCESS", True) -ARGO_ROLLOUTS = load_bool("ARGO_ROLLOUTS", False) +ARGO_ROLLOUTS = load_bool("ARGO_ROLLOUTS", True) # lowered case k8s kinds in a json array string. "[\"configmap\", \"secret\"]" RESOURCE_YAML_BLOCK_LIST = json.loads(os.environ.get("RESOURCE_YAML_BLOCK_LIST", "[]"))