Skip to content

Commit 98a98c4

Browse files
authored
Merge pull request #9178 from ruby/refine-release-task
Refine release task for the next patch release
2 parents f76ae61 + 31e5305 commit 98a98c4

File tree

4 files changed

+22
-10
lines changed

4 files changed

+22
-10
lines changed

.changelog.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,8 @@ changelog_label_mapping:
2424
"rubygems: skip changelog": null
2525

2626
patch_level_labels:
27-
- "rubygems: performance"
2827
- "rubygems: enhancement"
2928
- "rubygems: bug fix"
3029
- "rubygems: security"
31-
- "rubygems: deprecation"
3230
- "rubygems: documentation"
3331
- "rubygems: skip changelog"

Rakefile

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -254,10 +254,16 @@ desc "Upload release to S3"
254254
task :upload_to_s3 do
255255
require "aws-sdk-s3"
256256

257-
s3 = Aws::S3::Resource.new(region:"us-west-2")
257+
client = Aws::S3::Client.new(region: "us-west-2")
258+
transfer_manager = Aws::S3::TransferManager.new(client: client)
259+
258260
%w[zip tgz].each do |ext|
259-
obj = s3.bucket("oregon.production.s3.rubygems.org").object("rubygems/rubygems-#{v}.#{ext}")
260-
obj.upload_file("pkg/rubygems-#{v}.#{ext}", acl: "public-read")
261+
transfer_manager.upload_file(
262+
"pkg/rubygems-#{v}.#{ext}",
263+
bucket: "oregon.production.s3.rubygems.org",
264+
key: "rubygems/rubygems-#{v}.#{ext}",
265+
acl: "public-read"
266+
)
261267
end
262268
end
263269

@@ -706,6 +712,8 @@ namespace :bundler do
706712
Rake::Task["bundler:build_metadata:clean"].tap(&:reenable).invoke
707713
end
708714

715+
task "build" => ["bundler:release:check_ruby_version"]
716+
709717
desc "Push to rubygems.org"
710718
task "release:rubygem_push" => ["bundler:release:setup", "man:check", "bundler:build_metadata", "check_release_preparations", "bundler:release:github"]
711719

@@ -726,5 +734,9 @@ namespace :bundler do
726734

727735
Release.for_bundler(gemspec_version).create_for_github!
728736
end
737+
738+
task :check_ruby_version do
739+
raise "bundler:build need to released Ruby for using nokogiri" if RUBY_PATCHLEVEL.to_i < 0
740+
end
729741
end
730742
end

bundler/.changelog.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,8 @@ changelog_label_mapping:
1818
"bundler: skip changelog": null
1919

2020
patch_level_labels:
21-
- "bundler: performance"
2221
- "bundler: enhancement"
2322
- "bundler: bug fix"
2423
- "bundler: security"
25-
- "bundler: deprecation"
2624
- "bundler: documentation"
2725
- "bundler: skip changelog"

tool/release.rb

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,14 @@ def initialize(version)
144144
@previous_stable_branch = @level == :minor_or_major ? "#{segments[0]}.#{segments[1] - 1}" : @stable_branch
145145
@previous_stable_branch = "3.7" if @stable_branch == "4.0"
146146

147-
@previous_release_tag = if @level == :minor_or_major && !@prerelease
148-
"v#{@previous_stable_branch}.0"
147+
@previous_release_tag = if @level == :minor_or_major
148+
if @prerelease
149+
`git describe --tags --abbrev=0`.strip
150+
else
151+
"v#{@previous_stable_branch}.0"
152+
end
149153
else
150-
`git describe --tags --abbrev=0`.strip
154+
"v#{@stable_branch}.0"
151155
end
152156

153157
rubygems_version = segments.join(".").gsub(/([a-z])\.(\d)/i, '\1\2')

0 commit comments

Comments
 (0)