Improve reflection usage for Java 9+

SciJava Common's core use of reflection -- dependency injection -- still
requires reflection, and therefore SciJava Common is far from being
JPMS-modularizable. But these fixes do help SJC run better with Java 9+.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: ctrueden

src/main/java/org/scijava/event/bushe/AbstractProxySubscriber.java

@@ -1,9 +1,9 @@
 package org.scijava.event.bushe;
 
 import java.lang.ref.WeakReference;
-import java.lang.reflect.Method;
 import java.lang.reflect.AccessibleObject;
 import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
 
 /**
  * Common base class for EventService Proxies.
@@ -104,18 +104,26 @@ protected boolean retryReflectiveCallUsingAccessibleObject(Object[] args, Method
          AccessibleObject[] accessibleMethod = {subscriptionMethod};
          try {
             AccessibleObject.setAccessible(accessibleMethod, true);
-            Object returnValue = subscriptionMethod.invoke(obj, args);
-            return Boolean.valueOf(returnValue+"");
          } catch (SecurityException ex) {
+            // SecurityManager (Java 8 and earlier) denied setAccessible
+            accessibleTriedAndFailed = true;
+         } catch (RuntimeException ex) {
+            // InaccessibleObjectException (Java 9+) or similar denied setAccessible
             accessibleTriedAndFailed = true;
-         } catch (InvocationTargetException e1) {
-            throw new RuntimeException(message, e);
-         } catch (IllegalAccessException e1) {
-            throw new RuntimeException(message, e);
+         }
+         if (!accessibleTriedAndFailed) {
+            try {
+               Object returnValue = subscriptionMethod.invoke(obj, args);
+               return Boolean.valueOf(returnValue+"");
+            } catch (InvocationTargetException e1) {
+               throw new RuntimeException(message, e);
+            } catch (IllegalAccessException e1) {
+               throw new RuntimeException(message, e);
+            }
          }
       }
       if (accessibleTriedAndFailed) {
-         message = message + ".  An attempt was made to make the method accessible, but the SecurityManager denied the attempt.";
+         message = message + ".  An attempt was made to make the method accessible, but access was denied.";
       }
       throw new RuntimeException(message, e);
    }

src/main/java/org/scijava/util/Colors.java

@@ -115,8 +115,7 @@ public final class Colors {
 	public static final ColorRGB LIGHTBLUE = new ColorRGB(173, 216, 230);
 	public static final ColorRGB LIGHTCORAL = new ColorRGB(240, 128, 128);
 	public static final ColorRGB LIGHTCYAN = new ColorRGB(224, 255, 255);
-	public static final ColorRGB LIGHTGOLDENRODYELLOW = new ColorRGB(250, 250,
-		210);
+	public static final ColorRGB LIGHTGOLDENRODYELLOW = new ColorRGB(250, 250, 210);
 	public static final ColorRGB LIGHTGRAY = new ColorRGB(211, 211, 211);
 	public static final ColorRGB LIGHTGREEN = new ColorRGB(144, 238, 144);
 	public static final ColorRGB LIGHTGREY = LIGHTGRAY;
@@ -194,19 +193,15 @@ public final class Colors {
 	public static final ColorRGB YELLOW = new ColorRGB(255, 255, 0);
 	public static final ColorRGB YELLOWGREEN = new ColorRGB(154, 205, 50);
 
-	private static final Map<String, ColorRGB> COLORS =
-		new HashMap<>();
+	private static final Map<String, ColorRGB> COLORS = new HashMap<>();
 
 	static {
-		for (final Field f : Colors.class.getDeclaredFields()) {
+		for (final Field f : Colors.class.getFields()) {
 			final Object value;
 			try {
 				value = f.get(null);
 			}
-			catch (final IllegalArgumentException e) {
-				continue;
-			}
-			catch (final IllegalAccessException e) {
+			catch (final IllegalAccessException | IllegalArgumentException e) {
 				continue;
 			}
 			if (!(value instanceof ColorRGB)) continue; // not a color