Conversation
Member
flying-sheep
left a comment
flying-sheep
left a comment
There was a problem hiding this comment.
Oh wow, that looks super cool! Addresses all my previous concerns about manual specification of magic numbers for chunking, repetitive kernel wrapper code, and so on!
| from rapids_singlecell._cuda import _qc_cuda as _qc | ||
|
|
||
| if sparse.isspmatrix_csr(X): | ||
| _qc.sparse_qc_csr( |
flying-sheep
force-pushed
the
move-to-nanobind
branch
from
2105d37 to
dddd9e8
Compare
Comment on lines
+106
to
+109
| pattern: cibw-* | ||
| pattern: cibw-wheels-*-cu${{ matrix.cuda_major }}-* |
Member
There was a problem hiding this comment.
why change this? why is “just upload all wheels and the sdist together” not the right thing anymore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This for now is a test with precompiled cuda extensions.