Tighten types

Author: codetheweb

src/cli/commands/access-codes.ts

@@ -15,6 +15,7 @@ export default {
           return yargs.option("device-id", {
             describe: "filter by device ID",
             demandOption: true,
+            type: "string",
           })
         },
         async (argv) => {
@@ -37,9 +38,11 @@ export default {
             .option("device-id", {
               describe: "the device ID",
               demandOption: true,
+              type: "string",
             })
             .option("name", {
               describe: "the name of the access code",
+              type: "string",
             })
             .option("code", {
               describe: "the code",
@@ -80,6 +83,7 @@ export default {
           return yargs.positional("id", {
             describe: "the access code ID",
             demandOption: true,
+            type: "string",
           })
         },
         async (argv) => {

src/cli/commands/action-attempts.ts

@@ -13,6 +13,7 @@ export default {
         return yargs.positional("id", {
           describe: "the action attempt ID",
           demandOption: true,
+          type: "string",
         })
       },
       async (argv) => {

src/cli/commands/connect-webviews.ts

@@ -24,6 +24,7 @@ export default {
           return yargs.positional("id", {
             describe: "the connect webview ID",
             demandOption: true,
+            type: "string",
           })
         },
         async (argv) => {
@@ -56,7 +57,7 @@ export default {
             "connectWebviews.create",
             [
               {
-                accepted_providers: argv["accepted-providers"],
+                accepted_providers: argv["accepted-providers"] as Provider[],
               },
             ],
             argv

src/cli/commands/connected-accounts.ts

@@ -23,6 +23,7 @@ export default {
           return yargs.positional("id", {
             describe: "the connected account ID",
             demandOption: true,
+            type: "string",
           })
         },
         async (argv) => {

src/cli/commands/devices.ts

@@ -15,6 +15,7 @@ export default {
           return yargs.positional("id", {
             describe: "the device ID",
             demandOption: true,
+            type: "string",
           })
         },
         async (argv) => {

src/cli/commands/locks.ts

@@ -15,6 +15,7 @@ export default {
           return yargs.positional("id", {
             describe: "the lock ID",
             demandOption: true,
+            type: "string",
           })
         },
         async (argv) => {
@@ -42,6 +43,7 @@ export default {
           return yargs.positional("id", {
             describe: "the lock ID",
             demandOption: true,
+            type: "string",
           })
         },
         async (argv) => {
@@ -55,6 +57,7 @@ export default {
           return yargs.positional("id", {
             describe: "the lock ID",
             demandOption: true,
+            type: "string",
           })
         },
         async (argv) => {

src/cli/commands/workspaces.ts

@@ -9,16 +9,11 @@ export default {
     yargs
       .demandCommand()
       .command(
-        "get <id>",
-        "get a workspace",
-        (yargs) => {
-          return yargs.positional("id", {
-            describe: "the workspace ID",
-            demandOption: true,
-          })
-        },
+        "get",
+        "get the workspace associated with the current API key",
+        () => {},
         async (argv) => {
-          await executeCommand("workspaces.get", [argv.id], argv)
+          await executeCommand("workspaces.get", [], argv)
         }
       )
       .command(

src/cli/execute-command.ts

@@ -1,11 +1,15 @@
 import ora from "ora"
+import { Get } from "type-fest"
 import { paramCase } from "change-case"
 import Seam, { SeamAPIError } from ".."
 
-// todo: tighten types for args
-const executeCommand = async (
-  methodName: string,
-  args: any[],
+type ParametersByPath<Path extends string> = Parameters<
+  Exclude<Get<Seam, Path>, Seam>
+>
+
+const executeCommand = async <MethodPath extends string>(
+  methodName: MethodPath,
+  args: ParametersByPath<MethodPath>,
   executeArgs: { json?: boolean; quiet?: boolean }
 ) => {
   const displaySpinner = !(executeArgs.quiet || executeArgs.json)