Trivial cleanup #68
Open
Trivial cleanup #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains some changes that have been bugging me for a while, but are just annoying enough to not get around to. - remove `CPP` that’s only used to get default impls in some cases, - separate field and method imports from type and class imports[^1], - move CPP blocks to end of sections (pragmas, imports)[^2], and - shorten long lines. [^1]: This style of importing is slightly more robust, as it continues to work even when fields and methods are moved to top-level definitions. [^2]: Ormolu can’t format within CPP blocks, so putting it in the middle of a section prevents automatic moving of elements from one side of the CPP to the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains some changes that have been bugging me for a while, but are just annoying enough to not get around to.
CPPthat’s only used to get default impls in some cases,Footnotes
This style of importing is slightly more robust, as it continues to work even when fields and methods are moved to top-level definitions. ↩
Ormolu can’t format within CPP blocks, so putting it in the middle of a section prevents automatic moving of elements from one side of the CPP to the other. ↩