Skip to content

Commit 0af5acf

Browse files
fix(knowledge): parse connector query flags
1 parent eb7ca3e commit 0af5acf

2 files changed

Lines changed: 25 additions & 2 deletions

File tree

apps/sim/app/api/knowledge/migrated-routes.test.ts

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,12 @@ describe('migrated internal Knowledge routes', () => {
345345
counts: { active: 1, excluded: 0 },
346346
})
347347
const params = Promise.resolve({ id: 'knowledge-1', connectorId: 'connector-1' })
348-
const listResponse = await listConnectorDocuments(createMockRequest('GET'), { params })
348+
const listResponse = await listConnectorDocuments(
349+
new NextRequest(
350+
'http://localhost/api/knowledge/knowledge-1/connectors/connector-1/documents?includeExcluded=true'
351+
),
352+
{ params }
353+
)
349354
await expect(listResponse.json()).resolves.toEqual({
350355
success: true,
351356
data: {
@@ -355,6 +360,24 @@ describe('migrated internal Knowledge routes', () => {
355360
counts: { active: 1, excluded: 0 },
356361
},
357362
})
363+
expect(mocks.listConnectorDocuments).toHaveBeenLastCalledWith(
364+
expect.objectContaining({
365+
input: expect.objectContaining({ includeExcluded: true }),
366+
})
367+
)
368+
369+
const filteredListResponse = await listConnectorDocuments(
370+
new NextRequest(
371+
'http://localhost/api/knowledge/knowledge-1/connectors/connector-1/documents?includeExcluded=false'
372+
),
373+
{ params: Promise.resolve({ id: 'knowledge-1', connectorId: 'connector-1' }) }
374+
)
375+
expect(filteredListResponse.status).toBe(200)
376+
expect(mocks.listConnectorDocuments).toHaveBeenLastCalledWith(
377+
expect.objectContaining({
378+
input: expect.objectContaining({ includeExcluded: false }),
379+
})
380+
)
358381

359382
mocks.updateConnectorDocuments.mockResolvedValue({
360383
operation: 'exclude',

apps/sim/lib/api/contracts/knowledge/connectors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const deleteConnectorQuerySchema = z.object({
2727
})
2828

2929
export const connectorDocumentsQuerySchema = z.object({
30-
includeExcluded: z.boolean().optional(),
30+
includeExcluded: booleanQueryFlagSchema.optional(),
3131
})
3232

3333
export const connectorDocumentsPatchBodySchema = z.object({

0 commit comments

Comments
 (0)