fix(nuqs): resolve 7 PR review findings on URL query-param state

- logs: clear the log-details `tab` param when the sidebar closes so a
  lingering `?tab=trace` no longer carries into the next opened log;
  deep-linked tabs still open on first mount.
- logs dashboard: drive the in-memory workflow filtering off the same
  debounced search value the stats query uses (passed as a prop) so the
  chart and list stay consistent while typing.
- knowledge document: make the URL `chunk` param the single source of
  truth for the open chunk (back/forward, deep links, and external
  navigation now drive the editor) instead of a one-time useState seed.
- logs: drop the redundant `setUrlSearchQuery('')` after `resetFilters()`
  (resetFilters already clears `search`).
- files: use a per-call `{ history: 'replace' }` override for the
  `shareFileId` share-modal open/close writes so toggling the modal does
  not pollute the back/forward stack; folder navigation keeps `push`.
- tables + recently-deleted: trim search input before deriving the URL
  value so whitespace-only input no longer writes `?search=%20`.

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/files/files.tsx

@@ -303,7 +303,9 @@ export function Files() {
   const shareModal = shareFile ? (
     <ShareModal
       open
-      onOpenChange={(open) => !open && setFilesParams({ shareFileId: null })}
+      onOpenChange={(open) =>
+        !open && setFilesParams({ shareFileId: null }, { history: 'replace' })
+      }
       workspaceId={workspaceId}
       fileId={shareFile.id}
       fileName={shareFile.name}
@@ -995,7 +997,7 @@ export function Files() {
 
   const handleShareSelected = useCallback(() => {
     const file = selectedFileRef.current
-    if (file) setFilesParams({ shareFileId: file.id })
+    if (file) setFilesParams({ shareFileId: file.id }, { history: 'replace' })
   }, [setFilesParams])
 
   const handleBulkDelete = useCallback(() => {
@@ -1244,7 +1246,7 @@ export function Files() {
 
   const handleContextMenuShare = useCallback(() => {
     const item = contextMenuItemRef.current
-    if (item?.kind === 'file') setFilesParams({ shareFileId: item.file.id })
+    if (item?.kind === 'file') setFilesParams({ shareFileId: item.file.id }, { history: 'replace' })
     closeContextMenu()
   }, [closeContextMenu, setFilesParams])
 

apps/sim/app/workspace/[workspaceId]/files/search-params.ts

@@ -20,12 +20,15 @@ const parseAsNewFlag = createParser<boolean>({
  * truth.
  *
  * - `folderId` is the currently open folder; it is shareable, bookmarkable, and
- *   navigations between folders belong in the browser history (`history: 'push'`).
+ *   navigations between folders belong in the browser history (`history: 'push'`,
+ *   the group default).
  * - `new` marks a freshly-created file so the editor opens in compose mode; it is
  *   read once on mount and stripped as the route stabilizes.
  * - `shareFileId` deep-links a file's share dialog open. The modal opens when the
- *   id resolves to a loaded file; closing it clears the param. Opening it is a
- *   destination, so (like folder navigation) it lands in the browser history.
+ *   id resolves to a loaded file; closing it clears the param. Opening and
+ *   closing the modal use a per-call `{ history: 'replace' }` override so the
+ *   dialog toggle does not pollute the back/forward stack (a deep link still
+ *   opens it on load).
  */
 export const filesParsers = {
   folderId: parseAsString,
@@ -35,8 +38,10 @@ export const filesParsers = {
 
 /**
  * Shared nuqs options for files query state. Folder navigation is a destination,
- * so it lands in the browser history; defaults clear from the URL to keep links
- * clean.
+ * so the group default lands in the browser history; defaults clear from the URL
+ * to keep links clean. Non-navigation writes (the `shareFileId` modal toggle)
+ * pass a per-call `{ history: 'replace' }` override so they don't add back-stack
+ * entries.
  */
 export const filesUrlKeys = {
   history: 'push',

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx

@@ -188,8 +188,17 @@ export function Document({
 
   const [selectedChunks, setSelectedChunks] = useState<Set<string>>(() => new Set())
 
-  // Inline editor state
-  const [selectedChunkId, setSelectedChunkId] = useState<string | null>(() => chunkFromURL)
+  // Inline editor state. The open chunk is sourced directly from the URL `chunk`
+  // param (single source of truth) so back/forward, deep links, and external
+  // navigation drive the editor; opening/closing a chunk writes the param.
+  const selectedChunkId = chunkFromURL
+  const setSelectedChunkId = useCallback(
+    (chunkId: string | null) => {
+      // Opening a chunk is a destination (back closes it); clearing replaces.
+      void setDocumentParams({ chunk: chunkId }, chunkId !== null ? { history: 'push' } : undefined)
+    },
+    [setDocumentParams]
+  )
   const [isCreatingNewChunk, setIsCreatingNewChunk] = useState(false)
   const [isDirty, setIsDirty] = useState(false)
   const [saveStatus, setSaveStatus] = useState<SaveStatus>('idle')
@@ -303,7 +312,7 @@ export function Document({
     setIsCreatingNewChunk(false)
     setIsDirty(false)
     setSaveStatus('idle')
-  }, [])
+  }, [setSelectedChunkId])
 
   const guardDirtyAction = useCallback(
     (action: () => void) => {
@@ -420,7 +429,15 @@ export function Document({
         }
       }
     },
-    [selectedChunk, currentChunkIndex, displayChunks, currentPage, totalPages, goToPage]
+    [
+      selectedChunk,
+      currentChunkIndex,
+      displayChunks,
+      currentPage,
+      totalPages,
+      goToPage,
+      setSelectedChunkId,
+    ]
   )
 
   const handleNavigateChunk = useCallback(
@@ -444,7 +461,7 @@ export function Document({
 
   const handleShowTags = useCallback(() => setShowTagsModal(true), [])
   const handleShowDeleteDoc = useCallback(() => setShowDeleteDocumentDialog(true), [])
-  const handleClearSelectedChunk = useCallback(() => setSelectedChunkId(null), [])
+  const handleClearSelectedChunk = useCallback(() => setSelectedChunkId(null), [setSelectedChunkId])
 
   const breadcrumbs = useMemo<BreadcrumbItem[]>(
     () =>
@@ -516,7 +533,7 @@ export function Document({
       setIsDirty(false)
       setSaveStatus('idle')
     })
-  }, [guardDirtyAction])
+  }, [guardDirtyAction, setSelectedChunkId])
 
   const handleChunkCreated = useCallback(
     async (chunkId: string) => {
@@ -549,7 +566,7 @@ export function Document({
       }
       setTimeout(checkAndSelect, 0)
     },
-    [goToPage, totalPages]
+    [goToPage, totalPages, setSelectedChunkId]
   )
 
   const createAction = useMemo(
@@ -634,9 +651,12 @@ export function Document({
     [enabledFilter, goToPage]
   )
 
-  const handleChunkClick = useCallback((rowId: string) => {
-    setSelectedChunkId(rowId)
-  }, [])
+  const handleChunkClick = useCallback(
+    (rowId: string) => {
+      setSelectedChunkId(rowId)
+    },
+    [setSelectedChunkId]
+  )
 
   const handleToggleEnabled = useCallback(
     (chunkId: string) => {

apps/sim/app/workspace/[workspaceId]/logs/components/dashboard/dashboard.tsx

@@ -38,6 +38,12 @@ interface DashboardProps {
   stats?: DashboardStatsResponse
   isLoading: boolean
   error?: Error | null
+  /**
+   * Debounced search term. Comes pre-debounced from the parent (same value the
+   * dashboard stats query uses) so the in-memory workflow list filtering and the
+   * stats query stay in sync while typing.
+   */
+  searchQuery: string
 }
 
 /**
@@ -60,12 +66,12 @@ function toWorkflowExecution(wf: WorkflowStats): WorkflowExecution {
   }
 }
 
-function DashboardInner({ stats, isLoading, error }: DashboardProps) {
+function DashboardInner({ stats, isLoading, error, searchQuery }: DashboardProps) {
   const [selectedSegments, setSelectedSegments] = useState<Record<string, number[]>>({})
   const [lastAnchorIndices, setLastAnchorIndices] = useState<Record<string, number>>({})
   const lastAnchorIndicesRef = useRef<Record<string, number>>({})
 
-  const { workflowIds, searchQuery, toggleWorkflowId, timeRange } = useLogFilters()
+  const { workflowIds, toggleWorkflowId, timeRange } = useLogFilters()
 
   const { workspaceId } = useParams<{ workspaceId: string }>()
   const { data: allWorkflowList = [], isPending: isWorkflowsPending } = useWorkflows(workspaceId)

apps/sim/app/workspace/[workspaceId]/logs/logs.tsx

@@ -54,7 +54,11 @@ import type {
 import { Resource } from '@/app/workspace/[workspaceId]/components'
 import { useLogFilters } from '@/app/workspace/[workspaceId]/logs/hooks/use-log-filters'
 import { useSearchState } from '@/app/workspace/[workspaceId]/logs/hooks/use-search-state'
-import { executionIdParam } from '@/app/workspace/[workspaceId]/logs/search-params'
+import {
+  executionIdParam,
+  logDetailsTabParam,
+  logDetailsTabUrlKeys,
+} from '@/app/workspace/[workspaceId]/logs/search-params'
 import type { Suggestion } from '@/app/workspace/[workspaceId]/logs/types'
 import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider'
 import { getBlock } from '@/blocks/registry'
@@ -233,6 +237,14 @@ export default function Logs() {
   const [executionId] = useQueryState(executionIdParam.key, executionIdParam.parser)
   const [pendingExecutionId, setPendingExecutionId] = useState<string | null>(() => executionId)
 
+  // The log-details `tab` param is owned/written by the details panel, but the
+  // orchestrator must clear it when the panel closes so a lingering `?tab=trace`
+  // never carries over to the next log opened from the list.
+  const [, setLogDetailsTab] = useQueryState(logDetailsTabParam.key, {
+    ...logDetailsTabParam.parser,
+    ...logDetailsTabUrlKeys,
+  })
+
   // `urlSearchQuery` is the instant nuqs value (its URL write is debounced inside
   // `useLogFilters`); the query/filtering still debounce off it to avoid per-keystroke
   // fetches.
@@ -410,7 +422,10 @@ export default function Logs() {
   const handleCloseSidebar = useCallback(() => {
     dispatch({ type: 'CLOSE_SIDEBAR' })
     activeLogTabRef.current = 'overview'
-  }, [])
+    // Strip `tab` from the URL (back to the default) so reopening another log
+    // starts on the overview tab instead of inheriting the closed log's tab.
+    setLogDetailsTab(null)
+  }, [setLogDetailsTab])
 
   const handleActiveTabChange = useCallback((tab: string) => {
     activeLogTabRef.current = tab
@@ -459,9 +474,10 @@ export default function Logs() {
   }, [contextMenuLog, workflowIds, setWorkflowIds])
 
   const handleClearAllFilters = useCallback(() => {
+    // `resetFilters()` already clears `search` (sets it to null), so no separate
+    // search reset is needed here.
     resetFilters()
-    setUrlSearchQuery('')
-  }, [resetFilters, setUrlSearchQuery])
+  }, [resetFilters])
 
   const handleOpenPreview = useCallback(() => {
     if (contextMenuLog?.id) {
@@ -1079,6 +1095,7 @@ export default function Logs() {
                 stats={dashboardStatsQuery.data}
                 isLoading={dashboardStatsQuery.isLoading}
                 error={dashboardStatsQuery.error}
+                searchQuery={debouncedSearchQuery}
               />
             </div>
             {sidebarOverlay}

apps/sim/app/workspace/[workspaceId]/settings/components/recently-deleted/recently-deleted.tsx

@@ -162,7 +162,8 @@ export function RecentlyDeleted() {
   // it reads the instant value too.
   const setSearchTerm = useCallback(
     (value: string) => {
-      const next = value.length > 0 ? value : null
+      const trimmed = value.trim()
+      const next = trimmed.length > 0 ? trimmed : null
       setRecentlyDeletedFilters(
         { search: next },
         next === null ? undefined : { limitUrlUpdates: debounce(SEARCH_DEBOUNCE_MS) }

apps/sim/app/workspace/[workspaceId]/tables/tables.tsx

@@ -115,7 +115,8 @@ export function Tables() {
   // so it doesn't recompute on every keystroke.
   const setSearchTerm = useCallback(
     (value: string) => {
-      const next = value.length > 0 ? value : null
+      const trimmed = value.trim()
+      const next = trimmed.length > 0 ? trimmed : null
       setTableFilters(
         { search: next },
         next === null ? undefined : { limitUrlUpdates: debounce(SEARCH_DEBOUNCE_MS) }