fix(agent): map the non-OpenAI finish reasons compatible vendors actually emit

Author: waleedlatif1

apps/sim/providers/finish-reason.test.ts

@@ -66,6 +66,39 @@ describe('normalizeFinishReason', () => {
     expect(normalizeFinishReason('pause_turn')).toBe('other')
   })
 
+  /**
+   * Values confirmed against each vendor's own enum by a per-provider documentation
+   * sweep. Several are the routine success path on open-weight models, so leaving
+   * them unclassified would misreport healthy runs.
+   */
+  it('classifies the non-OpenAI vocabularies of compatible vendors', () => {
+    expect(normalizeFinishReason('model_length')).toBe('length') // Mistral
+    expect(normalizeFinishReason('eos')).toBe('stop') // Together
+    expect(normalizeFinishReason('eos_token')).toBe('stop') // LiteLLM/HuggingFace
+    expect(normalizeFinishReason('error')).toBe('error') // Mistral, OpenRouter, Together
+    expect(normalizeFinishReason('insufficient_system_resource')).toBe('error') // DeepSeek
+    expect(normalizeFinishReason('network_error')).toBe('error') // Z.ai
+    expect(normalizeFinishReason('sensitive')).toBe('content_filter') // Z.ai
+  })
+
+  it('classifies the Gemini and Vertex values absent from the TS enum', () => {
+    expect(normalizeFinishReason('MODEL_ARMOR')).toBe('content_filter') // Vertex only
+    expect(normalizeFinishReason('ESCALATION')).toBe('content_filter')
+    expect(normalizeFinishReason('MALFORMED_RESPONSE')).toBe('error')
+    expect(normalizeFinishReason('MISSING_THOUGHT_SIGNATURE')).toBe('error')
+  })
+
+  /**
+   * A server-aborted tool loop is not a request to execute tools, and a repetition
+   * cutoff is a normal finish rather than a failure — both would mislead a workflow
+   * branching on the value.
+   */
+  it('does not overclaim on aborted or degenerate stops', () => {
+    expect(normalizeFinishReason('too_many_tool_calls')).toBe('other')
+    expect(normalizeFinishReason('repetition')).toBe('other')
+    expect(normalizeFinishReason('abort')).toBe('other')
+  })
+
   it('degrades an unrecognized value to other rather than throwing', () => {
     expect(normalizeFinishReason('some_future_reason')).toBe('other')
     expect(normalizeFinishReason('OTHER')).toBe('other')

apps/sim/providers/finish-reason.ts

@@ -16,7 +16,7 @@ export type AgentFinishReason =
   | 'tool_calls'
   /** Blocked or refused by a safety system. */
   | 'content_filter'
-  /** The provider reported the generation itself as malformed. */
+  /** The provider reported the generation itself as failed or malformed. */
   | 'error'
   /** Reported, but not a case this vocabulary distinguishes. */
   | 'other'
@@ -41,6 +41,37 @@ const NORMALIZED_BY_RAW = new Map<string, AgentFinishReason>([
   // OpenAI Responses reports truncation through `incomplete_details.reason`.
   ['max_output_tokens', 'length'],
 
+  /** Mistral separates the model's own max length from the caller's `max_tokens`. */
+  ['model_length', 'length'],
+
+  /**
+   * Natural end-of-sequence. Together and HuggingFace-backed proxies report the
+   * model's EOS token separately from a caller-supplied stop sequence, so without
+   * these the routine success path on open-weight models is unclassified.
+   */
+  ['eos', 'stop'],
+  ['eos_token', 'stop'],
+
+  /**
+   * A generation the provider itself reported as failed. Mistral, OpenRouter,
+   * Together and Fireworks all spell this `error`; the DeepSeek and Z.ai values are
+   * the same class with a stated cause.
+   */
+  ['error', 'error'],
+  ['insufficient_system_resource', 'error'],
+  ['network_error', 'error'],
+
+  /** Z.ai (GLM) sensitive-content block. */
+  ['sensitive', 'content_filter'],
+
+  /**
+   * Cut short with no outcome to report, on vLLM and NIM-hosted models. vLLM treats
+   * a repetition cutoff as a normal finish rather than a failure, so it is not
+   * `error`.
+   */
+  ['abort', 'other'],
+  ['repetition', 'other'],
+
   // Anthropic Messages, shared by Bedrock's Converse API.
   ['end_turn', 'stop'],
   ['stop_sequence', 'stop'],
@@ -72,6 +103,12 @@ const NORMALIZED_BY_RAW = new Map<string, AgentFinishReason>([
   ['image_recitation', 'content_filter'],
   ['malformed_function_call', 'error'],
   ['unexpected_tool_call', 'error'],
+  ['malformed_response', 'error'],
+  ['missing_thought_signature', 'error'],
+  ['model_armor', 'content_filter'],
+  ['escalation', 'content_filter'],
+  /** A runaway tool loop the server aborted, not a request to execute tools. */
+  ['too_many_tool_calls', 'other'],
   ['language', 'other'],
   ['other', 'other'],
   ['no_image', 'other'],