fix(workflows): close application composition gaps

Author: TheodoreSpeaks

apps/sim/app/api/workflows/[id]/deployments/[version]/route.test.ts

@@ -0,0 +1,116 @@
+/**
+ * @vitest-environment node
+ */
+import { createMockRequest } from '@sim/testing'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+const mocks = vi.hoisted(() => ({
+  activate: vi.fn(),
+  parseRequest: vi.fn(),
+  read: vi.fn(),
+  session: vi.fn(),
+  update: vi.fn(),
+}))
+
+vi.mock('@/lib/api/server', () => ({
+  getValidationErrorMessage: vi.fn(),
+  parseRequest: mocks.parseRequest,
+}))
+
+vi.mock('@/lib/api/server/routes', () => ({
+  InternalUnauthenticatedError: class InternalUnauthenticatedError extends Error {},
+  internalSessionAuth: { authenticate: mocks.session },
+}))
+
+vi.mock('@/lib/core/utils/with-route-handler', () => ({
+  withRouteHandler: (handler: unknown) => handler,
+}))
+
+vi.mock('@/lib/workflows/application/deployments', () => ({
+  activateWorkflowVersion: { execute: mocks.activate },
+  updateWorkflowVersion: { execute: mocks.update },
+}))
+
+vi.mock('@/lib/workflows/application/read-workflow-version', () => ({
+  readWorkflowVersion: { execute: mocks.read },
+}))
+
+import { PATCH } from '@/app/api/workflows/[id]/deployments/[version]/route'
+
+describe('workflow deployment version PATCH', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    mocks.session.mockResolvedValue({ kind: 'session', userId: 'user-1', sessionId: 'session-1' })
+    mocks.activate.mockResolvedValue({
+      deployedAt: new Date('2026-01-01T00:00:00Z'),
+      warnings: undefined,
+      activeDeployment: null,
+      latestDeploymentAttempt: null,
+      name: 'Release 2',
+      description: 'Production',
+    })
+    mocks.update.mockResolvedValue({ name: 'Release 2', description: 'Production' })
+  })
+
+  it('sends activation and optional metadata through one application command', async () => {
+    mocks.parseRequest.mockResolvedValue({
+      success: true,
+      data: {
+        params: { id: 'workflow-1', version: 2 },
+        body: { isActive: true, name: 'Release 2', description: 'Production' },
+      },
+    })
+
+    const response = await PATCH(
+      createMockRequest(
+        'PATCH',
+        undefined,
+        {},
+        'http://localhost/api/workflows/workflow-1/deployments/2'
+      ),
+      { params: Promise.resolve({ id: 'workflow-1', version: '2' }) }
+    )
+
+    expect(response.status).toBe(200)
+    expect(await response.json()).toMatchObject({
+      success: true,
+      name: 'Release 2',
+      description: 'Production',
+    })
+    expect(mocks.activate).toHaveBeenCalledWith(
+      expect.objectContaining({
+        input: expect.objectContaining({
+          workflowId: 'workflow-1',
+          version: 2,
+          name: 'Release 2',
+          description: 'Production',
+        }),
+      })
+    )
+    expect(mocks.update).not.toHaveBeenCalled()
+  })
+
+  it('keeps metadata-only edits on the existing update-version operation', async () => {
+    mocks.parseRequest.mockResolvedValue({
+      success: true,
+      data: {
+        params: { id: 'workflow-1', version: 2 },
+        body: { isActive: false, name: 'Release 2' },
+      },
+    })
+
+    const response = await PATCH(
+      createMockRequest(
+        'PATCH',
+        undefined,
+        {},
+        'http://localhost/api/workflows/workflow-1/deployments/2'
+      ),
+      { params: Promise.resolve({ id: 'workflow-1', version: '2' }) }
+    )
+
+    expect(response.status).toBe(200)
+    expect(mocks.update).toHaveBeenCalledOnce()
+    expect(mocks.activate).not.toHaveBeenCalled()
+  })
+})

apps/sim/app/api/workflows/[id]/deployments/[version]/route.ts

@@ -89,25 +89,13 @@ export const PATCH = withRouteHandler(
             transition: 'activate',
             requestId,
             analytics: 'human',
+            name,
+            description,
           },
           request,
         })
 
-        let updatedName: string | null | undefined
-        let updatedDescription: string | null | undefined
         if (name !== undefined || description !== undefined) {
-          const updated = await updateWorkflowVersion.execute({
-            principal,
-            input: {
-              workflowId: id,
-              version: versionNum,
-              name,
-              description,
-            },
-            request,
-          })
-          updatedName = updated.name
-          updatedDescription = updated.description
           logger.info(
             `[${requestId}] Updated deployment version ${version} metadata during activation`,
             { name, description }
@@ -120,8 +108,8 @@ export const PATCH = withRouteHandler(
           warnings: activateResult.warnings,
           activeDeployment: activateResult.activeDeployment ?? null,
           latestDeploymentAttempt: activateResult.latestDeploymentAttempt ?? null,
-          ...(updatedName !== undefined && { name: updatedName }),
-          ...(updatedDescription !== undefined && { description: updatedDescription }),
+          ...(name !== undefined && { name: activateResult.name ?? null }),
+          ...(description !== undefined && { description: activateResult.description ?? null }),
         })
       }
 

apps/sim/lib/copilot/tools/handlers/deployment/deploy.test.ts

@@ -2,6 +2,7 @@
  * @vitest-environment node
  */
 import { dbChainMockFns, resetDbChainMock } from '@sim/testing'
+import { getErrorMessage } from '@sim/utils/errors'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const {
@@ -25,7 +26,7 @@ const {
 vi.mock('@/lib/copilot/application/execute-workflow-use-case', () => ({
   executeCopilotWorkflowUseCase: mockExecuteCopilotWorkflowUseCase,
   messageForCopilotWorkflowError: (error: unknown, fallback: string) =>
-    error instanceof Error ? error.message : fallback,
+    getErrorMessage(error, fallback),
 }))
 
 vi.mock('@/lib/workflows/orchestration', () => ({

apps/sim/lib/copilot/tools/handlers/deployment/manage.test.ts

@@ -8,6 +8,7 @@ import {
   workflowsOrchestrationMock,
   workflowsOrchestrationMockFns,
 } from '@sim/testing'
+import { getErrorMessage } from '@sim/utils/errors'
 import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
 import type { ExecutionContext } from '@/lib/copilot/request/types'
 
@@ -21,7 +22,7 @@ const { ensureWorkflowAccessMock, checkNeedsRedeploymentMock, mockExecuteCopilot
 vi.mock('@/lib/copilot/application/execute-workflow-use-case', () => ({
   executeCopilotWorkflowUseCase: mockExecuteCopilotWorkflowUseCase,
   messageForCopilotWorkflowError: (error: unknown, fallback: string) =>
-    error instanceof Error ? error.message : fallback,
+    getErrorMessage(error, fallback),
 }))
 
 const performRevertToVersionMock = workflowsOrchestrationMockFns.mockPerformRevertToVersion