fix(workflows): complete application boundary migration

Author: TheodoreSpeaks

apps/sim/app/api/chat/manage/[id]/route.ts

@@ -12,17 +12,14 @@ import { isDev } from '@/lib/core/config/env-flags'
 import { encryptSecret } from '@/lib/core/security/encryption'
 import { getEmailDomain } from '@/lib/core/utils/urls'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
+import { checkNeedsRedeployment } from '@/lib/workflows/deployment-status'
 import {
   getWorkflowDeploymentSummary,
   performChatUndeploy,
   performFullDeploy,
 } from '@/lib/workflows/orchestration'
 import { checkChatAccess } from '@/app/api/chat/utils'
-import {
-  checkNeedsRedeployment,
-  createErrorResponse,
-  createSuccessResponse,
-} from '@/app/api/workflows/utils'
+import { createErrorResponse, createSuccessResponse } from '@/app/api/workflows/utils'
 import {
   ChatDeployAuthNotAllowedError,
   validateChatDeployAuth,

apps/sim/app/api/v2/workflows/[id]/deploy/route.test.ts

@@ -10,6 +10,7 @@ const mocks = vi.hoisted(() => ({
 
 vi.mock('@/lib/api/server/routes', () => ({
   createInternalSessionOrExecutorAuth: vi.fn(() => ({ kind: 'internal-workflow' })),
+  createV2ResourceConcealmentPolicy: vi.fn(() => ({ kind: 'conceal-workflow' })),
   defineV2JsonRoute: mocks.defineRoute,
   v2ApiKeyAuth: { kind: 'v2-api-key' },
   v2RateLimits: { publicApi: { kind: 'public-api' } },
@@ -40,7 +41,6 @@ describe('/api/v2/workflows/[id]/deploy route definitions', () => {
         workflowId: 'workflow-1',
         name: undefined,
         description: undefined,
-        analytics: 'human',
       })
     )
 

apps/sim/app/api/v2/workflows/[id]/deploy/route.ts

@@ -30,7 +30,6 @@ export const POST = defineV2JsonRoute({
     name: body.name,
     description: body.description ?? undefined,
     requestId: generateRequestId(),
-    analytics: 'human' as const,
   }),
   useCase: deployWorkflow,
   present: (result) => ({

apps/sim/app/api/v2/workflows/[id]/execute/route.test.ts

@@ -236,7 +236,22 @@ describe('POST /api/v2/workflows/[id]/execute', () => {
       rateLimitSubscription: null,
       keyType: 'workspace',
     })
-    dbChainMockFns.limit.mockResolvedValue([applicationContext])
+    dbChainMockFns.limit
+      .mockResolvedValueOnce([
+        {
+          workflowId: workflowRecord.id,
+          workflow: workflowRecord,
+          workspaceId: workflowRecord.workspaceId,
+        },
+      ])
+      .mockResolvedValueOnce([
+        {
+          id: applicationContext.workspaceId,
+          organizationId: applicationContext.workspaceOrganizationId,
+          allowPersonalApiKeys: applicationContext.allowPersonalApiKeys,
+          billedAccountUserId: applicationContext.billedAccountUserId,
+        },
+      ])
     mockAuthorize.mockResolvedValue({ allowed: true, workflow: workflowRecord })
     mockClaimExecutionId.mockImplementation(async (executionId: string) => ({
       key: `workflow-execution-id:${executionId}`,
@@ -420,9 +435,23 @@ describe('POST /api/v2/workflows/[id]/execute', () => {
       rateLimitSubscription: null,
       keyType: 'personal',
     })
-    dbChainMockFns.limit.mockResolvedValueOnce([
-      { ...applicationContext, allowPersonalApiKeys: false },
-    ])
+    dbChainMockFns.limit.mockReset()
+    dbChainMockFns.limit
+      .mockResolvedValueOnce([
+        {
+          workflowId: workflowRecord.id,
+          workflow: workflowRecord,
+          workspaceId: workflowRecord.workspaceId,
+        },
+      ])
+      .mockResolvedValueOnce([
+        {
+          id: applicationContext.workspaceId,
+          organizationId: applicationContext.workspaceOrganizationId,
+          allowPersonalApiKeys: false,
+          billedAccountUserId: applicationContext.billedAccountUserId,
+        },
+      ])
 
     const res = await callExecute({ input: {} })
 
@@ -487,6 +516,7 @@ describe('POST /api/v2/workflows/[id]/execute', () => {
   })
 
   it('runs the anonymous public path sync but refuses async', async () => {
+    dbChainMockFns.limit.mockReset()
     dbChainMockFns.limit.mockResolvedValueOnce([
       { isPublicApi: true, isDeployed: true, userId: 'owner-1', workspaceId: 'workspace-1' },
     ])
@@ -526,6 +556,7 @@ describe('POST /api/v2/workflows/[id]/execute', () => {
   })
 
   it('401s non-public workflows without a key', async () => {
+    dbChainMockFns.limit.mockReset()
     dbChainMockFns.limit.mockResolvedValueOnce([
       { isPublicApi: false, isDeployed: true, userId: 'owner-1', workspaceId: 'workspace-1' },
     ])
@@ -551,6 +582,7 @@ describe('POST /api/v2/workflows/[id]/execute', () => {
   })
 
   it('returns a safe error when canonical workflow lookup fails', async () => {
+    dbChainMockFns.limit.mockReset()
     dbChainMockFns.limit.mockRejectedValueOnce(new Error('database connection details'))
 
     const response = await callExecute({ input: {} })

apps/sim/app/api/v2/workflows/[id]/rollback/route.test.ts

@@ -9,6 +9,7 @@ const mocks = vi.hoisted(() => ({
 
 vi.mock('@/lib/api/server/routes', () => ({
   createInternalSessionOrExecutorAuth: vi.fn(() => ({ kind: 'internal-workflow' })),
+  createV2ResourceConcealmentPolicy: vi.fn(() => ({ kind: 'conceal-workflow' })),
   defineV2JsonRoute: mocks.defineRoute,
   v2ApiKeyAuth: { kind: 'v2-api-key' },
   v2RateLimits: { publicApi: { kind: 'public-api' } },
@@ -35,7 +36,6 @@ describe('/api/v2/workflows/[id]/rollback route definition', () => {
         workflowId: 'workflow-1',
         version: undefined,
         transition: 'rollback',
-        analytics: 'human',
       })
     )
 

apps/sim/app/api/v2/workflows/[id]/rollback/route.ts

@@ -26,7 +26,6 @@ export const POST = defineV2JsonRoute({
     version: body.version,
     transition: 'rollback' as const,
     requestId: generateRequestId(),
-    analytics: 'human' as const,
   }),
   useCase: activateWorkflowVersion,
   present: (result) => ({