Skip to content

Commit c0a049b

Browse files
committed
fix: removed optional params from extract top level deps
1 parent 7dce595 commit c0a049b

File tree

2 files changed

+15
-18
lines changed

2 files changed

+15
-18
lines changed

lib/dep-graph-builders/pnpm/build-dep-graph-pnpm.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,7 @@ export const buildDepGraphPnpm = async (
4242
const topLevelDeps = getTopLevelDeps(pkgJson, options);
4343

4444
const extractedTopLevelDeps =
45-
lockFileParser.extractTopLevelDependencies(
46-
options,
47-
pkgJson.name,
48-
pkgJson.version,
49-
importer,
50-
) || {};
45+
lockFileParser.extractTopLevelDependencies(options, importer) || {};
5146

5247
for (const name of Object.keys(topLevelDeps)) {
5348
if (!extractedTopLevelDeps[name]) {

lib/dep-graph-builders/pnpm/lockfile-parser/lockfile-parser.ts

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { PnpmWorkspaceArgs } from '../../types';
1+
import { PnpmProject, PnpmWorkspaceArgs } from '../../types';
22
import {
33
NormalisedPnpmPkg,
44
NormalisedPnpmPkgs,
@@ -75,22 +75,21 @@ export abstract class PnpmLockfileParser {
7575
includeOptionalDeps?: boolean;
7676
includePeerDeps?: boolean;
7777
},
78-
pkgName: string,
79-
pkgVersion: string,
8078
importer?: string,
8179
): PnpmDeps {
8280
let root = this.rawPnpmLock;
8381
if (importer) {
82+
const { name, version } = this.workspaceArgs?.projectsVersionMap[
83+
importer
84+
] as PnpmProject;
8485
if (
8586
// Return early because dependencies were already normalized for this importer
8687
// as part of another's importer dependency and stored in extractedPackages
87-
this.extractedPackages[`${pkgName}@${pkgVersion}`] &&
88-
!isEmpty(
89-
this.extractedPackages[`${pkgName}@${pkgVersion}`].dependencies,
90-
)
88+
this.extractedPackages[`${name}@${version}`] &&
89+
!isEmpty(this.extractedPackages[`${name}@${version}`].dependencies)
9190
) {
9291
return this.normalizedPkgToTopLevel(
93-
this.extractedPackages[`${pkgName}@${pkgVersion}`],
92+
this.extractedPackages[`${name}@${version}`],
9493
);
9594
}
9695
root = this.rawPnpmLock.importers[importer];
@@ -118,10 +117,13 @@ export abstract class PnpmLockfileParser {
118117
: {};
119118

120119
if (importer) {
121-
this.extractedPackages[`${pkgName}@${pkgVersion}`] = {
122-
id: `${pkgName}@${pkgVersion}`,
123-
name: pkgName,
124-
version: pkgVersion,
120+
const { name, version } = this.workspaceArgs?.projectsVersionMap[
121+
importer
122+
] as PnpmProject;
123+
this.extractedPackages[`${name}@${version}`] = {
124+
id: `${name}@${version}`,
125+
name: version,
126+
version: version,
125127
dependencies: this.topLevelDepsToNormalizedPkgs(prodDeps),
126128
devDependencies: this.topLevelDepsToNormalizedPkgs(devDeps),
127129
optionalDependencies: this.topLevelDepsToNormalizedPkgs(optionalDeps),

0 commit comments

Comments
 (0)