Merge pull request #511 from sam1el/fix/pipeline

Fix/pipeline

Author: Robthreefold

.eslintignore

@@ -0,0 +1,100 @@
+import { defineConfig } from "eslint/config";
+import checkFile from "eslint-plugin-check-file";
+import globals from "globals";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const currentFilename = fileURLToPath(import.meta.url);
+const currentDirname = path.dirname(currentFilename);
+const compat = new FlatCompat({
+    baseDirectory: currentDirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default defineConfig([
+    {
+        ignores: ["node_modules/**", "dist/**"],
+    },
+    {
+    extends: compat.extends(
+        "eslint:recommended",
+    "plugin:@typescript-eslint/eslint-recommended",
+    "plugin:@typescript-eslint/recommended",
+    "prettier",
+    ),
+
+
+    plugins: {
+        "check-file": checkFile,
+    },
+
+    languageOptions: {
+        globals: {
+            ...globals.node,
+        },
+
+        parser: tsParser,
+        ecmaVersion: 6,
+        sourceType: "commonjs",
+    },
+
+    rules: {
+        "check-file/folder-naming-convention": ["error", {
+            "src/**/": "KEBAB_CASE",
+            "test/lib/**/": "KEBAB_CASE",
+            "test/unit/**/": "KEBAB_CASE",
+        }],
+
+        "@typescript-eslint/naming-convention": ["error", {
+            selector: "default",
+            format: ["camelCase", "UPPER_CASE"],
+        }, {
+            selector: "typeLike",
+            format: ["PascalCase"],
+        }, {
+            selector: "typeParameter",
+            format: ["PascalCase"],
+        }, {
+            selector: "interface",
+            format: ["PascalCase"],
+            custom: {
+                regex: "^I[A-Z]",
+                match: false,
+            },
+        }],
+
+        "@typescript-eslint/explicit-module-boundary-types": "off",
+        "@typescript-eslint/explicit-function-return-type": "off",
+        "@typescript-eslint/no-explicit-any": "off",
+        "no-prototype-builtins": "off",
+        "@typescript-eslint/no-empty-function": "off",
+        "@typescript-eslint/no-non-null-assertion": "off",
+        "@typescript-eslint/no-var-requires": "warn",
+        "@typescript-eslint/consistent-type-imports": "error",
+        "@typescript-eslint/no-use-before-define": "off",
+        "@typescript-eslint/no-unused-vars": "error",
+        "no-buffer-constructor": "error",
+        "no-import-assign": "error",
+    },
+
+} ,
+
+// Test-specific config (flat config uses separate entries instead of overrides)
+{
+    files: ["test/**", "test/**/*.ts"],
+    languageOptions: {
+        parser: tsParser,
+    },
+    rules: {
+        // test fixtures frequently use kebab-case keys and require() imports
+    "@typescript-eslint/naming-convention": "off",
+        "@typescript-eslint/no-require-imports": "off",
+        "@typescript-eslint/no-unused-vars": "off",
+        "@typescript-eslint/no-var-requires": "off",
+    },
+}
+]);

eslint.config.mjs

@@ -46,7 +46,6 @@
     "@octokit/auth-app": "^5.0.0",
     "@octokit/plugin-retry": "4.0.3",
     "@octokit/rest": "19.0.5",
-    "tslib": "^2.6.0",
     "base-64": "^1.0.0",
     "bottleneck": "2.19.5",
     "bunyan": "1.8.15",
@@ -62,6 +61,7 @@
     "snyk-request-manager": "1.8.4",
     "source-map-support": "^0.5.16",
     "split": "1.0.1",
+    "tslib": "^2.6.0",
     "yargs": "16.2.0"
   },
   "devDependencies": {
@@ -77,18 +77,18 @@
     "@types/node": "20.11.1",
     "@types/parse-link-header": "1.0.0",
     "@types/split": "1.0.0",
-    "@typescript-eslint/eslint-plugin": "4.28.1",
-    "@typescript-eslint/parser": "4.28.1",
-    "eslint": "7.30.0",
-    "eslint-config-prettier": "^6.10.0",
-    "eslint-plugin-check-file": "1.2.3",
+    "@typescript-eslint/eslint-plugin": "^8.46.0",
+    "@typescript-eslint/parser": "^8.46.0",
+    "eslint": "^9.37.0",
+    "eslint-config-prettier": "^10.1.8",
+    "eslint-plugin-check-file": "^3.3.0",
     "jest": "^29.7.0",
     "nock": "^13.2.1",
     "prettier": "2.7.1",
     "semantic-release": "17.3.0",
     "ts-jest": "^29.1.5",
     "tsc-watch": "^4.1.0",
-    "typescript": "4.5",
+    "typescript": "^5.9.3",
     "uuid": "9.0.0"
   },
   "overrides": {

package.json

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/naming-convention */
+// Removed unused eslint-disable directive
 // Mock for GitHub Cloud App authentication and API calls
 export const mockGitHubAppToken = 'mock-github-app-token';
 export const mockInstallationId = 12345;

test/scripts/__mocks__/github-cloud-app.ts

@@ -1,4 +1,4 @@
-// eslint-disable-next-line @typescript-eslint/naming-convention
+// Removed unused eslint-disable-next-line directive
 export class requestsManager {
   params: unknown;
   constructor(params: unknown = {}) {

test/scripts/__mocks__/snyk-request-manager.ts

@@ -25,8 +25,8 @@ describe('GitHub Cloud App import:data integration', () => {
     });
 
     // Mock the loadFile function by creating a temporary file
-    const fs = require('fs'); // eslint-disable-line @typescript-eslint/no-var-requires
-    const path = require('path'); // eslint-disable-line @typescript-eslint/no-var-requires
+  const fs = require('fs');
+  const path = require('path');
     const tempFile = path.join(__dirname, 'temp-orgs-data.json');
 
     try {
@@ -64,8 +64,8 @@ describe('GitHub Cloud App import:data integration', () => {
       ],
     });
 
-    const fs = require('fs'); // eslint-disable-line @typescript-eslint/no-var-requires
-    const path = require('path'); // eslint-disable-line @typescript-eslint/no-var-requires
+  const fs = require('fs');
+  const path = require('path');
     const tempFile = path.join(__dirname, 'temp-orgs-data.json');
 
     try {
@@ -106,8 +106,8 @@ describe('GitHub Cloud App import:data integration', () => {
       ],
     });
 
-    const fs = require('fs'); // eslint-disable-line @typescript-eslint/no-var-requires
-    const path = require('path'); // eslint-disable-line @typescript-eslint/no-var-requires
+  const fs = require('fs');
+  const path = require('path');
     const tempFile = path.join(__dirname, 'temp-orgs-data.json');
 
     try {