fix: [OSM-1797] Fixing bug that caused a failure when running snyk test in a multi-project folder (#213)

* fix: adding test fixture to provoke error

* fix: getting the project path from the assets file

Author: dotkas

lib/nuget-parser/index.ts

@@ -188,11 +188,23 @@ Will attempt to build dependency graph anyway, but the operation might fail.`);
   const nugetFrameworksParserLocation = nugetFrameworksParser.generate();
   await dotnet.restore(nugetFrameworksParserLocation);
 
+  // Access the path of this project, to ensure we get the right .csproj file, in case of multiples present
+  const projectPath = projectAssets.project.restore.projectPath;
+  if (!projectPath) {
+    console.log(
+      `\x1b[33m⚠ WARNING\x1b[0m: Could not detect any projectPath in the project assets file, if your solution contains multiple projects in the same folder, this operation might fail.`,
+    );
+  }
+
   // Loop through all TargetFrameworks supplied and generate a dependency graph for each.
   const results: DotnetCoreV2Results = [];
   for (const decidedTargetFramework of decidedTargetFrameworks) {
     // Run `dotnet publish` to create a self-contained publishable binary with included .dlls for assembly version inspection.
-    const publishDir = await dotnet.publish(safeRoot, decidedTargetFramework);
+    const publishDir = await dotnet.publish(
+      // Attempt to feed it the full path to the project file itself, as multiple could exist. If that fails, don't break the flow, just send the folder as previously
+      projectPath || safeRoot,
+      decidedTargetFramework,
+    );
 
     // Then inspect the dependency graph for the runtimepackage's assembly versions.
     const filename = `${projectNameFromManifestFile}.deps.json`;

lib/nuget-parser/types.ts

@@ -54,9 +54,20 @@ export enum ManifestType {
   PAKET = 'paket',
 }
 
+interface Restore {
+  projectUniqueName: string;
+  projectName: string;
+  projectPath: string;
+  packagesPath: string;
+  outputPath: string;
+  projectStyle: string;
+  configFilePaths: string[];
+  originalTargetFrameworks: string[];
+}
+
 interface Project {
   version: string;
-  restore: Record<string, any>;
+  restore: Restore;
   frameworks: Record<string, any>;
   runtimeIdentifierGraphPath: string;
 }

test/fixtures/dotnetcore/dotnet_8_multiple_projects_same_folder/dotnet_8_first.csproj

@@ -0,0 +1,10 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net8.0</TargetFramework>
+    <RuntimeIdentifier>linux-x64</RuntimeIdentifier>
+  </PropertyGroup>
+  <ItemGroup>
+    <PackageReference Include="NSubstitute" Version="4.3.0" />
+  </ItemGroup>
+</Project>

test/fixtures/dotnetcore/dotnet_8_multiple_projects_same_folder/dotnet_8_second.csproj

@@ -0,0 +1,10 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net8.0</TargetFramework>
+    <RuntimeIdentifier>linux-x64</RuntimeIdentifier>
+  </PropertyGroup>
+  <ItemGroup>
+    <PackageReference Include="NSubstitute" Version="4.3.0" />
+  </ItemGroup>
+</Project>