[bug] negative filter not working anymore

[gaeljw]

Describe the bug

After upgrade to 4.10.2, negative filters seems to not work anymore: they filter out too many results.

To reproduce

(Regex enabled in all my tests but that doesn't seem to change anything)

Here's an example:

• query file:gitlab-ci.yml "maven:test" (no negative filter), 28 matches
• query file:gitlab-ci.yml "maven:test" "maven:test_with_jacoco" (still no negative filter), 1 match only => meaning only of the 28 match has both strings
• query: file:gitlab-ci.yml "maven:test" -"maven:test_with_jacoco": 0 matches with v4.10.2 whereas it was giving the expected 27 matches with v4.9.2

Sourcebot deployment information

Sourcebot version (e.g. v3.0.1): 4.10.2

Additional information

No response

[brendan-kellam]

Heya, could you try file:gitlab-ci.yml "maven:test" -("maven:test_with_jacoco") (note the added parentheses)

[gaeljw]

Adding the parentheses does the trick @brendan-kellam ! Thanks.

Do you know why we need the parenthesis in this situation but apparently not always? For instance in another context -lang:Java seems to work fine.

[brendan-kellam]

Awesome! The - token is being interpreted literally for search patterns (ie -foo matches the regexp /-foo/), vs it being interpreted as a negation operator with group operators () and search filters lang:. This is another subtle change to how the query syntax is parsed in v4.10.0. Thanks for finding these!

I think this behaviour makes more sense, so going to close this issue as resolved