updated method value check to allow passing of false values - fixes #1946

aschkenasy · aschkenasy · commit 19538c44a585 · 2025-12-05T09:03:13.000-05:00
diff --git a/src/Tasks/Backup/DbDumperFactory.php b/src/Tasks/Backup/DbDumperFactory.php
@@ -121,7 +121,7 @@ protected static function processExtraDumpParameters(array $dumpConfiguration, D
 
     protected static function callMethodOnDumper(DbDumper $dbDumper, string $methodName, mixed $methodValue): DbDumper
     {
-        if (! $methodValue) {
+        if (! isset($methodValue)) {
             $dbDumper->$methodName();
 
             return $dbDumper;

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ protected static function processExtraDumpParameters(array $dumpConfiguration, D`
`121`	`121`
`122`	`122`	`protected static function callMethodOnDumper(DbDumper $dbDumper, string $methodName, mixed $methodValue): DbDumper`
`123`	`123`	`{`
`124`		`- if (! $methodValue) {`
	`124`	`+ if (! isset($methodValue)) {`
`125`	`125`	`$dbDumper->$methodName();`
`126`	`126`
`127`	`127`	`return $dbDumper;`