review changes

Author: h3adex

docs/stackit_routing-table_update.md

@@ -23,10 +23,10 @@ stackit routing-table update ROUTING_TABLE_ID [flags]
   $ stackit routing-table update xxx --description foo --organization-id yyy --network-area-id zzz
 
   Disables the dynamic routes of a routing-table with ID "xxx" in organization with ID "yyy" and network-area with ID "zzz"
-  $ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --disable-dynamic-routes
+  $ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --dynamic-routes=false
 
   Disables the system routes of a routing-table with ID "xxx" in organization with ID "yyy" and network-area with ID "zzz"
-  $ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --disable-system-routes
+  $ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --system-routes=false
 ```
 
 ### Options

internal/cmd/routingtable/create/create.go

@@ -3,7 +3,6 @@ package create
 import (
 	"context"
 	"fmt"
-	"strings"
 
 	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
@@ -12,7 +11,6 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/client"
-	"github.com/stackitcloud/stackit-cli/internal/pkg/tables"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/types"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 	"github.com/stackitcloud/stackit-sdk-go/services/iaas"
@@ -147,40 +145,16 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APICli
 }
 
 func outputResult(p *print.Printer, outputFormat string, routingTable *iaas.RoutingTable) error {
+	if routingTable == nil {
+		return fmt.Errorf("routing-table is nil")
+	}
+
+	if routingTable.Id == nil {
+		return fmt.Errorf("create routing-table id is empty")
+	}
+
 	return p.OutputResult(outputFormat, routingTable, func() error {
-		if routingTable == nil {
-			return fmt.Errorf("create routing-table response is empty")
-		}
-
-		if routingTable.Id == nil {
-			return fmt.Errorf("create routing-table id is empty")
-		}
-
-		var labels []string
-		if routingTable.Labels != nil && len(*routingTable.Labels) > 0 {
-			for key, value := range *routingTable.Labels {
-				labels = append(labels, fmt.Sprintf("%s: %s", key, value))
-			}
-		}
-
-		table := tables.NewTable()
-		table.SetHeader("ID", "NAME", "DESCRIPTION", "DEFAULT", "LABELS", "SYSTEM ROUTES", "DYNAMIC ROUTES", "CREATED AT", "UPDATED AT")
-		table.AddRow(
-			utils.PtrString(routingTable.Id),
-			utils.PtrString(routingTable.Name),
-			utils.PtrString(routingTable.Description),
-			utils.PtrString(routingTable.Default),
-			strings.Join(labels, "\n"),
-			utils.PtrString(routingTable.SystemRoutes),
-			utils.PtrString(routingTable.DynamicRoutes),
-			utils.ConvertTimePToDateTimeString(routingTable.CreatedAt),
-			utils.ConvertTimePToDateTimeString(routingTable.UpdatedAt),
-		)
-
-		err := table.Display(p)
-		if err != nil {
-			return fmt.Errorf("render table: %w", err)
-		}
+		p.Outputf("Created Routing-Table with ID %q\n", utils.PtrString(routingTable.Id))
 		return nil
 	})
 }

internal/cmd/routingtable/update/update.go

@@ -60,11 +60,11 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 			),
 			examples.NewExample(
 				`Disables the dynamic routes of a routing-table with ID "xxx" in organization with ID "yyy" and network-area with ID "zzz"`,
-				"$ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --disable-dynamic-routes",
+				"$ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --dynamic-routes=false",
 			),
 			examples.NewExample(
 				`Disables the system routes of a routing-table with ID "xxx" in organization with ID "yyy" and network-area with ID "zzz"`,
-				"$ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --disable-system-routes",
+				"$ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --system-routes=false",
 			),
 		),
 		RunE: func(cmd *cobra.Command, args []string) error {

internal/pkg/services/routingtable/utils/utils.go

@@ -2,7 +2,6 @@ package utils
 
 import (
 	"fmt"
-	"strings"
 	"time"
 
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
@@ -47,11 +46,11 @@ func ExtractRouteDetails(route iaas.Route) RouteDetails {
 	}
 
 	if route.Labels != nil && len(*route.Labels) > 0 {
-		var labels []string
+		stringMap := make(map[string]string)
 		for key, value := range *route.Labels {
-			labels = append(labels, fmt.Sprintf("%s: %s", key, value))
+			stringMap[key] = fmt.Sprintf("%v", value)
 		}
-		routeDetails.Labels = strings.Join(labels, "\n")
+		routeDetails.Labels = utils.JoinStringMap(stringMap, ": ", "\n")
 	}
 
 	if route.CreatedAt != nil {