fix: add review findings

Author: bahkauv70

internal/cmd/project/create/create.go

@@ -95,7 +95,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				return fmt.Errorf("create project: %w", err)
 			}
 
-			return outputResult(p, model.OutputFormat, *model, resp)
+			return outputResult(p, *model, resp)
 		},
 	}
 	configureFlags(cmd)
@@ -212,11 +212,14 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *resourceman
 	return req, nil
 }
 
-func outputResult(p *print.Printer, outputFormat string, model inputModel, resp *resourcemanager.Project) error {
+func outputResult(p *print.Printer, model inputModel, resp *resourcemanager.Project) error {
 	if resp == nil {
 		return fmt.Errorf("response is empty")
 	}
-	switch outputFormat {
+	if model.GlobalFlagModel == nil {
+		return fmt.Errorf("globalflags are empty")
+	}
+	switch model.OutputFormat {
 	case print.JSONOutputFormat:
 		details, err := json.MarshalIndent(resp, "", "  ")
 		if err != nil {

internal/cmd/project/create/create_test.go

@@ -361,24 +361,23 @@ func TestBuildRequest(t *testing.T) {
 
 func Test_outputResult(t *testing.T) {
 	type args struct {
-		outputFormat string
-		model        inputModel
-		resp         *resourcemanager.Project
+		model inputModel
+		resp  *resourcemanager.Project
 	}
 	tests := []struct {
 		name    string
 		args    args
 		wantErr bool
 	}{
-		{"empty", args{}, true},
-		{"base", args{"", inputModel{}, &resourcemanager.Project{}}, false},
+		{"empty", args{model: inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{}}}, true},
+		{"base", args{inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{}}, &resourcemanager.Project{}}, false},
 	}
 
 	p := print.NewPrinter()
 	p.Cmd = NewCmd(p)
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if err := outputResult(p, tt.args.outputFormat, tt.args.model, tt.args.resp); (err != nil) != tt.wantErr {
+			if err := outputResult(p, tt.args.model, tt.args.resp); (err != nil) != tt.wantErr {
 				t.Errorf("outputResult() error = %v, wantErr %v", err, tt.wantErr)
 			}
 		})

internal/cmd/project/member/list/list.go

@@ -89,7 +89,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				members = members[:*model.Limit]
 			}
 
-			return outputResult(p, model.OutputFormat, *model, members)
+			return outputResult(p, *model, members)
 		},
 	}
 	configureFlags(cmd)
@@ -145,7 +145,10 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *authorizati
 	return req
 }
 
-func outputResult(p *print.Printer, outputFormat string, model inputModel, members []authorization.Member) error {
+func outputResult(p *print.Printer, model inputModel, members []authorization.Member) error {
+	if model.GlobalFlagModel == nil {
+		return fmt.Errorf("globalflags are empty")
+	}
 	sortFn := func(i, j int) bool {
 		switch model.SortBy {
 		case "subject":
@@ -158,7 +161,7 @@ func outputResult(p *print.Printer, outputFormat string, model inputModel, membe
 	}
 	sort.SliceStable(members, sortFn)
 
-	switch outputFormat {
+	switch model.OutputFormat {
 	case print.JSONOutputFormat:
 		// Show details
 		details, err := json.MarshalIndent(members, "", "  ")

internal/cmd/project/member/list/list_test.go

@@ -211,25 +211,26 @@ func TestBuildRequest(t *testing.T) {
 
 func Test_outputResult(t *testing.T) {
 	type args struct {
-		outputFormat string
-		model        inputModel
-		members      []authorization.Member
+		model   inputModel
+		members []authorization.Member
 	}
 	tests := []struct {
 		name    string
 		args    args
 		wantErr bool
 	}{
-		{"empty", args{}, false},
-		{"base", args{"", inputModel{
-			Subject: utils.Ptr("subject"),
-			Limit:   nil,
-			SortBy:  "",
+		{"empty", args{model: inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{}}}, false},
+		{"base", args{inputModel{
+			GlobalFlagModel: &globalflags.GlobalFlagModel{},
+			Subject:         utils.Ptr("subject"),
+			Limit:           nil,
+			SortBy:          "",
 		}, nil}, false},
-		{"complete", args{"", inputModel{
-			Subject: utils.Ptr("subject"),
-			Limit:   nil,
-			SortBy:  "",
+		{"complete", args{inputModel{
+			GlobalFlagModel: &globalflags.GlobalFlagModel{},
+			Subject:         utils.Ptr("subject"),
+			Limit:           nil,
+			SortBy:          "",
 		},
 			[]authorization.Member{
 				{Role: utils.Ptr("role1"), Subject: utils.Ptr("subject1")},
@@ -242,7 +243,7 @@ func Test_outputResult(t *testing.T) {
 	p.Cmd = NewCmd(p)
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if err := outputResult(p, tt.args.outputFormat, tt.args.model, tt.args.members); (err != nil) != tt.wantErr {
+			if err := outputResult(p, tt.args.model, tt.args.members); (err != nil) != tt.wantErr {
 				t.Errorf("outputResult() error = %v, wantErr %v", err, tt.wantErr)
 			}
 		})