Skip to content

feat: add napi/create-int64 and napi/create-uint64#11428

Merged
kgryte merged 11 commits intostdlib-js:developfrom
Kaushikgtm:add-napi-create-int64-uint64
Apr 18, 2026
Merged

feat: add napi/create-int64 and napi/create-uint64#11428
kgryte merged 11 commits intostdlib-js:developfrom
Kaushikgtm:add-napi-create-int64-uint64

Conversation

@Kaushikgtm
Copy link
Copy Markdown
Contributor

@Kaushikgtm Kaushikgtm commented Apr 13, 2026 •
edited
Loading

Resolves a part of #10922

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

Adds @stdlib/napi/create-int64 and @stdlib/napi/create-uint64, wrapping
napi_create_bigint_int64 and napi_create_bigint_uint64 (N-API v6+). These
unblock the TODOs in blas/base/icamax, blas/base/idamax, etc., which need to
return 64-bit integers.

  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 13, 2026

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 13, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 13, 2026

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

1 similar comment
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 13, 2026

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 13, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
napi/create-int64 $\color{green}147/147$
$\color{green}+0.00%$ 		$\color{green}5/5$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{green}147/147$
$\color{green}+0.00%$
napi/create-uint64 $\color{green}147/147$
$\color{green}+0.00%$ 		$\color{green}5/5$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{green}147/147$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Kaushikgtm and others added 2 commits April 13, 2026 11:58
@kgryte kgryte requested a review from a team April 18, 2026 07:11
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/include/stdlib/napi/create_int64.h Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/include/stdlib/napi/create_int64.h Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/lib/native.js
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/lib/native.js Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/lib/native.js Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/lib/native.js Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/src/addon.c
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/src/main.c Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/test/test.native.js Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/README.md Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/README.md Outdated
kgryte added 2 commits April 18, 2026 00:19
@kgryte
Apply suggestions from code review
310fd8e 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
chore: remove file
81e3cbd 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/include/stdlib/napi/create_uint64.h Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/include/stdlib/napi/create_uint64.h Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/lib/native.js
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/lib/native.js Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/src/addon.c Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/src/main.c Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/test/test.native.js Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/README.md Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/README.md Outdated
@kgryte
Apply suggestions from code review
ccb5a51 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/include/stdlib/napi/create_uint64.h Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/include/stdlib/napi/create_uint64.h Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/include/stdlib/napi/create_uint64.h Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/src/addon.c Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/src/addon.c Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/src/addon.c Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/README.md Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/README.md Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/README.md Outdated
@kgryte
Apply suggestions from code review
e4f8a5c 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/README.md Outdated
@kgryte
Apply suggestions from code review
201e758 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added Feature Issue or pull request for adding a new feature. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 1 labels Apr 18, 2026
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/manifest.json Outdated
@kgryte
Apply suggestions from code review
a703fb0 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 18, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 18, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 18, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 18, 2026
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-int64/lib/native.js Outdated
kgryte
kgryte reviewed Apr 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/napi/create-uint64/lib/native.js Outdated
@kgryte
Apply suggestions from code review
b2406b8 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Apr 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after considerable clean-up. In the future, if you are going to add new packages, they should be added in separate PRs.

@kgryte kgryte merged commit 0c116e3 into stdlib-js:develop Apr 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. review: 1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kaushikgtm @stdlib-bot @kgryte