Conflicting error handling in SetPitchNumberOffsetBlock flow #4818
Description
Description: I found a logical inconsistency in js/blocks/PitchBlocks.js within the SetPitchNumberOffsetBlock class.
In the flow method, the code checks if the arguments are null and triggers an error message (activity.errorMsg) if they are. However, immediately after raising the error, the code assigns default values to those arguments and proceeds to execute the pitch offset action anyway.
Impact: This creates a confusing User Experience. The user is presented with an error message indicating failure, yet the program continues to execute using defaults, essentially succeeding silently. The logic should be consistent: either valid input is mandatory (stop execution on error), or defaults should be applied silently without alerting the user.