fix the crash with device connection not closing successfully; add more accurate error messages for connection issues

Author: superus8r

app/src/main/java/org/kabiri/android/usbterminal/arduino/ArduinoHelper.kt

@@ -62,7 +62,17 @@ class ArduinoHelper(private val context: Context,
                     _liveInfoOutput.postValue(context.getString(R.string.helper_info_usb_permission_requested))
                 } else {
                     _liveErrorOutput.postValue(context.getString(R.string.helper_error_device_not_found))
-                    connection.close()
+                    try {
+                        connection.close()
+                    } catch (e: UninitializedPropertyAccessException) {
+                        _liveErrorOutput.postValue(context.getString(
+                            R.string.helper_error_connection_not_ready_to_close))
+                        _liveErrorOutput.postValue(e.message)
+                    } catch (e: Exception) {
+                        _liveErrorOutput.postValue(context.getString(
+                            R.string.helper_error_connection_failed_to_close))
+                        _liveErrorOutput.postValue(e.message)
+                    }
                 }
             }
         } else {

app/src/main/res/values/strings.xml

@@ -18,6 +18,8 @@
     <string name="helper_error_serial_connection_not_opened">\nPort not opened - There might be a problem with the serial connection to Arduino</string>
     <string name="helper_error_write_problem">Serial Write encountered an error:</string>
     <string name="helper_error_connection_closed_unexpectedly">Device connection was closed unexpectedly</string>
+    <string name="helper_error_connection_not_ready_to_close">No device connection to close</string>
+    <string name="helper_error_connection_failed_to_close">Device connection failed to close</string>
     <string name="helper_info_serial_connection_opened">\nSerial Connection Opened</string>
     <string name="helper_info_usb_permission_requested">Requested permission to access the USB device…</string>
     <string name="helper_info_checking_attached_usb_devices">\nChecking attached USB devices…</string>