[Bug]: Black screen on "Lightning Connection" screen

[pwltr]

Going into this TX and clicking "Connection" to see the channel close details worked first. But on a second try I got a black screen of death.

Screen_Recording_20260116_195522_Bitkit.mp4

[ovitrif]

@pwltr Thank you for filing the issue for this bug 🙏🏻 , I encountered the bug rather often but missed adding an issue for it.

There are more issues related to the unpolished nav to Connection Detail Screen UI/UX:

2. The current screen navigation implementation when we tap on "Connection" button in the (transfer) activity detail view is sub-par UX quality.

• Expected: it opens the related connection detail screen directly.
• Actual It passes through, opening the Connection List Screen first, then opening the detail screen.

3. The predictive navigation gestures around the (lightning) connection detail screen are broken. They're working decent for any other screen I tested (see video)

4. The implementation of these screens (both list and detail) are quite outdated and not making good use of the fact that we can now pass around directly as Route parameters any bitkit-core or ldk-node object. Proper refactoring for this would most likely fix point 3 as a side-effect.

Video showcasing how the predictive back gesture is broken for connection detail screen:

predictive.mp4

[ovitrif]

I ran Gemini to analyze the "Video showcasing how the predictive back gesture is broken for connection detail screen" and generate a prompt for Claude to understand what's in it so we can delegate a fix attempt:

# Context
I I need help fixing a UX bug regarding the Android 14+ Predictive Back gesture in the `LightningConnectionDetail` view.

# The Issue (Video Analysis)
I shared a video recording of the bug which shows the following behavior:
1.  **Action:** I perform the back gesture (swiping from the left/right edge) while inside the `LightningConnectionDetail` screen.
2.  **Current Outcome:** The animation is janky, and If I play enough with the gesture by swiping left and right without lifting my finger, it even ends up with rendering the detail view completely blank/black screen. Then if I lift my finger it ends up on the fully black screen.

3.  **Expected Outcome:** The gesture should trigger the "Cross-Activity" or in-app navigation animation, peeling back the Detail view to reveal the previous screen (the Lightning Connections list) smoothly, as this works for any other screen I tested.

# Todo Before Fix Attempt
Please analyze the navigation logic to the `ChannelDetailScreen` view via the `LightningConnectionsScreen`.

[ovitrif]

@claude Proceed to implement a fix for this issue.
Make sure to gather context from PR description, title and all the PR comments as there's more issues revealed.

[claude]

Claude finished @ovitrif's task in 2m 57s —— View job • claude/issue-668-20260120-2012 • Create PR ➔

---

Fixed the Connection screen black screen bug ✅

Tasks

• Gather context from issue and comments
• Read CLAUDE.md for repo guidelines
• Find and analyze navigation to Connection Detail screen
• Identify root cause of black screen issue
• Implement fix for black screen
• Fix predictive back gesture issues
• Fix sub-par navigation UX
• Commit and push changes

Root Cause Analysis

The black screen bug occurred due to a race condition in the navigation flow:

1. Previous problematic flow: ActivityDetailScreen → saves channelId to savedStateHandle → navigates to ConnectionsNav → LightningConnectionsScreen reads from savedStateHandle → delays 200ms → finds channel → navigates to ChannelDetail

2. The bug: ChannelDetailScreen had an early return if selectedChannel was null (line 94). When navigating before the channel was selected, it rendered nothing (black screen).

3. Predictive back gesture issue: During the back gesture animation, the empty early return created a blank composable that broke the animation.

Solution Implemented

Fixed all three issues mentioned in the bug report:

1. ✅ Black screen bug - Changed from early return to showing a loading state when channel is null
2. ✅ Sub-par navigation UX - Removed intermediate step through Connections List screen by passing channelId directly
3. ✅ Broken predictive back gesture - Eliminated the blank composable state that was breaking the animation

Technical changes:

• Changed Routes.ChannelDetail from data object to data class with channelId: String parameter
• Updated ChannelDetailScreen to accept channelId and fetch/select the channel on initialization via LaunchedEffect
• Updated all navigation calls to pass the channelId directly: Routes.ChannelDetail(channelId)
• Added a proper loading state UI instead of early return when channel is null
• Simplified the navigation flow in LightningConnectionsScreen to navigate directly without the intermediate channel selection step

Files Changed

• app/src/main/java/to/bitkit/ui/ContentView.kt - Updated route definition and navigation graph
• app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt - Added channelId parameter, loading state, and channel fetching
• app/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsScreen.kt - Simplified navigation to pass channelId directly

---

Branch |

[thisispav]

[Bug] Attempting to purchase a channel from LNBIG results in black screen / weird UX when checking channel details (refer to video)

bitkit_logs_1772373882448.zip
https://github.com/user-attachments/assets/2d1cac0b-735b-4e21-bee3-2f530ebba3f1