docs: remove outdated JUnit 4 dependency references from JUnit 5 page#11584
Closed
PreAgile wants to merge 5 commits intotestcontainers:mainfrom
Closed
docs: remove outdated JUnit 4 dependency references from JUnit 5 page#11584PreAgile wants to merge 5 commits intotestcontainers:mainfrom
PreAgile wants to merge 5 commits intotestcontainers:mainfrom
Conversation
Member
|
Hi @PreAgile, with all due respect do not raise PRs with unrelated changes. Also, PR is out-dated and I started addressing those changes in previous commits. Have you checked the contributing site? Before raising a PR, see if the issue has been triaged by maintainers. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove outdated references to JUnit 4.x dependency from the JUnit 5
integration documentation page.
Problem
The JUnit 5 docs page mentions that Testcontainers core depends on
JUnit 4.x, but this dependency was removed in #10805.
Two references are outdated:
Fix
Closes #11578