chore: address pr comments

Author: designcode

scripts/install.sh

@@ -178,7 +178,7 @@ cleanup_old_install() {
   for PROFILE_FILE in "$HOME/.zshrc" "$HOME/.bashrc" "$HOME/.bash_profile" "$HOME/.profile"; do
     if [ -f "$PROFILE_FILE" ] && grep -q '\.tigris/bin' "$PROFILE_FILE" 2>/dev/null; then
       # Filter out the Tigris CLI comment and export line
-      grep -v '# Tigris CLI' "$PROFILE_FILE" | grep -v '\.tigris/bin' > "${PROFILE_FILE}.tmp"
+      { grep -v '# Tigris CLI' "$PROFILE_FILE" | grep -v '\.tigris/bin' || true; } > "${PROFILE_FILE}.tmp"
       mv "${PROFILE_FILE}.tmp" "$PROFILE_FILE"
       info "Removed old PATH entry from $PROFILE_FILE"
     fi

src/lib/buckets/create.ts

@@ -164,8 +164,8 @@ export default async function create(options: Record<string, unknown>) {
           message: c.name,
         })),
       } as Parameters<typeof prompt>[0]);
-      if (regions.length === 0) {
-        printFailure(context, 'At least one region is required');
+      if (regions.length < 2) {
+        printFailure(context, 'Dual region requires at least two regions');
         process.exit(1);
       }
       parsedLocations = parseLocations(regions);

src/lib/buckets/set-migration.ts

@@ -31,16 +31,31 @@ export default async function setMigration(options: Record<string, unknown>) {
     process.exit(1);
   }
 
-  if (disable) {
-    const config = await getStorageConfig();
-    const selectedOrg = getSelectedOrganization();
-    const finalConfig = {
-      ...config,
-      ...(selectedOrg && !config.organizationId
-        ? { organizationId: selectedOrg }
-        : {}),
-    };
+  if (
+    disable &&
+    (bucket !== undefined ||
+      endpoint !== undefined ||
+      region !== undefined ||
+      accessKey !== undefined ||
+      secretKey !== undefined)
+  ) {
+    printFailure(
+      context,
+      'Cannot use --disable with --bucket, --endpoint, --region, --access-key, or --secret-key'
+    );
+    process.exit(1);
+  }
 
+  const config = await getStorageConfig();
+  const selectedOrg = getSelectedOrganization();
+  const finalConfig = {
+    ...config,
+    ...(selectedOrg && !config.organizationId
+      ? { organizationId: selectedOrg }
+      : {}),
+  };
+
+  if (disable) {
     const { error } = await setBucketMigration(name, {
       dataMigration: { enabled: false },
       config: finalConfig,
@@ -63,15 +78,6 @@ export default async function setMigration(options: Record<string, unknown>) {
     process.exit(1);
   }
 
-  const config = await getStorageConfig();
-  const selectedOrg = getSelectedOrganization();
-  const finalConfig = {
-    ...config,
-    ...(selectedOrg && !config.organizationId
-      ? { organizationId: selectedOrg }
-      : {}),
-  };
-
   const { error } = await setBucketMigration(name, {
     dataMigration: {
       enabled: true,

src/lib/buckets/set.ts

@@ -63,7 +63,6 @@ export default async function set(options: Record<string, unknown>) {
   if (
     access === undefined &&
     locations === undefined &&
-    deprecatedRegion === undefined &&
     allowObjectAcl === undefined &&
     disableDirectoryListing === undefined &&
     cacheControl === undefined &&

src/specs.yaml

@@ -19,6 +19,17 @@ definitions:
       value: GLACIER_IR
       description: Lowest-cost storage for long-lived data that is rarely accessed and requires retrieval in milliseconds.
 
+  transition_tier_options: &transition_tier_options
+    - name: Infrequent Access
+      value: STANDARD_IA
+      description: Lower-cost storage for data that is accessed less frequently but requires rapid access when needed.
+    - name: Archive
+      value: GLACIER
+      description: Low-cost storage for data archiving. Long-term data archiving with infrequent access.
+    - name: Instant Retrieval Archive
+      value: GLACIER_IR
+      description: Lowest-cost storage for long-lived data that is rarely accessed and requires retrieval in milliseconds.
+
   consistency_options: &consistency_options
     - name: Default
       value: default
@@ -760,7 +771,7 @@ commands:
           - name: storage-class
             description: Target storage class to transition objects to
             alias: s
-            options: *tier_options
+            options: *transition_tier_options
           - name: days
             description: Transition objects after this many days
             alias: d