Skip to content

Commit 84e1bf6

Browse files
committed
fix: normalize underscore max old space flags
1 parent ead1e5a commit 84e1bf6

3 files changed

Lines changed: 14 additions & 1 deletion

File tree

.changeset/quiet-pots-relax.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@trigger.dev/core": patch
3+
---
4+
5+
Replace underscore-form Node.js max-old-space-size flags when normalizing NODE_OPTIONS.

packages/core/src/v3/machines/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export function nodeOptionsWithMaxOldSpaceSize(
4545
let options = existingOptions ?? "";
4646

4747
//remove existing max-old-space-size flag
48-
options = options.replace(/--max-old-space-size=\d+/g, "").trim();
48+
options = options.replace(/--max[-_]old[-_]space[-_]size=\d+/g, "").trim();
4949

5050
//get max-old-space-size flag
5151
const flag = maxOldSpaceSizeFlag(machine, overhead);

packages/core/src/v3/machines/max-old-space.test.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,14 @@ describe("nodeOptionsWithMaxOldSpaceSize", () => {
3636
expect(result).toBe(`--inspect ${expectedFlag}`);
3737
});
3838

39+
it("replaces existing max_old_space_size flag", () => {
40+
const result = nodeOptionsWithMaxOldSpaceSize(
41+
"--max_old_space_size=4096 --inspect",
42+
testMachine
43+
);
44+
expect(result).toBe(`--inspect ${expectedFlag}`);
45+
});
46+
3947
it("handles multiple existing max-old-space-size flags", () => {
4048
const result = nodeOptionsWithMaxOldSpaceSize(
4149
"--max-old-space-size=4096 --inspect --max-old-space-size=8192",

0 commit comments

Comments
 (0)