fix(core): do not retry a metric reader that failed to shut down

Author: nicktrn

packages/core/src/v3/otel/tracingSDK.test.ts

@@ -88,10 +88,13 @@ class FailingMetricReader extends MetricReader {
 }
 
 class FailingShutdownMetricReader extends MetricReader {
+  shutdownAttempts = 0;
+
   protected async onForceFlush(): Promise<void> {}
 
   protected async onShutdown(): Promise<void> {
-    throw new Error("reader shutdown failed");
+    this.shutdownAttempts++;
+    throw new Error(`reader shutdown failed (attempt ${this.shutdownAttempts})`);
   }
 }
 
@@ -202,4 +205,30 @@ describe("TracingSDK shutdown", () => {
 
     expect(recordingReader.shutdownCount).toBeGreaterThan(0);
   });
+
+  it("does not retry a metric reader that failed to shut down", async () => {
+    const failingReader = new FailingShutdownMetricReader();
+
+    const tracingSDK = new TracingSDK({
+      url: "http://localhost:1",
+      forceFlushTimeoutMillis: 5_000,
+      diagLogLevel: "none",
+      metricReaders: [failingReader],
+    });
+
+    await tracingSDK.shutdown().catch(() => {});
+
+    expect(failingReader.shutdownAttempts).toBe(1);
+  });
+
+  it("reports the original shutdown failure, not a later one", async () => {
+    const tracingSDK = new TracingSDK({
+      url: "http://localhost:1",
+      forceFlushTimeoutMillis: 5_000,
+      diagLogLevel: "none",
+      metricReaders: [new FailingShutdownMetricReader()],
+    });
+
+    await expect(tracingSDK.shutdown()).rejects.toThrow("attempt 1");
+  });
 });

packages/core/src/v3/otel/tracingSDK.ts

@@ -359,11 +359,8 @@ export class TracingSDK {
   }
 
   private async _shutdownMetricReadersSerially() {
-    try {
-      await this._eachMetricReaderSerially("shut down", (reader) => reader.shutdown());
-    } finally {
-      await this._meterProvider.shutdown();
-    }
+    await this._eachMetricReaderSerially("shut down", (reader) => reader.shutdown());
+    await this._meterProvider.shutdown();
   }
 
   private async _eachMetricReaderSerially(

packages/core/src/v3/taskContext/otelProcessors.test.ts

@@ -39,7 +39,7 @@ function gauge(name: string, values: number[]): MetricData {
     aggregationTemporality: AggregationTemporality.CUMULATIVE,
     dataPointType: DataPointType.GAUGE,
     dataPoints: values.map((value) => ({
-      attributes: { "process.cpu.state": String(value) },
+      attributes: { "process.cpu.state": "user" },
       startTime: [1786481102, 584000000],
       endTime: [1786481102, 698000000],
       value,
@@ -71,7 +71,7 @@ function histogram(name: string, sums: number[]): MetricData {
     aggregationTemporality: AggregationTemporality.DELTA,
     dataPointType: DataPointType.HISTOGRAM,
     dataPoints: sums.map((sum) => ({
-      attributes: { sum: String(sum) },
+      attributes: { "task.status": "completed" },
       startTime: [1786481102, 584000000],
       endTime: [1786481102, 698000000],
       value: {