Skip to content

Commit aef74de

Browse files
committed
Fixed TS errors by adding ERROR_GROUP to cases where it was missing
1 parent 9fe8269 commit aef74de

File tree

4 files changed

+30
-2
lines changed

4 files changed

+30
-2
lines changed

apps/webapp/app/presenters/v3/ApiAlertChannelPresenter.server.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ export const ApiAlertType = z.enum([
1717
"attempt_failure",
1818
"deployment_failure",
1919
"deployment_success",
20+
"error_group",
2021
]);
2122

2223
export type ApiAlertType = z.infer<typeof ApiAlertType>;
@@ -85,6 +86,8 @@ export class ApiAlertChannelPresenter {
8586
return "deployment_failure";
8687
case "DEPLOYMENT_SUCCESS":
8788
return "deployment_success";
89+
case "ERROR_GROUP":
90+
return "error_group";
8891
default:
8992
assertNever(alertType);
9093
}
@@ -100,6 +103,8 @@ export class ApiAlertChannelPresenter {
100103
return "DEPLOYMENT_FAILURE";
101104
case "deployment_success":
102105
return "DEPLOYMENT_SUCCESS";
106+
case "error_group":
107+
return "ERROR_GROUP";
103108
default:
104109
assertNever(alertType);
105110
}

apps/webapp/app/presenters/v3/ErrorGroupPresenter.server.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,20 @@ export class ErrorGroupPresenter extends BasePresenter {
289289
firstSeen: parseClickHouseDateTime(record.first_seen),
290290
lastSeen: parseClickHouseDateTime(record.last_seen),
291291
affectedVersions: [],
292+
state: {
293+
status: "UNRESOLVED" as const,
294+
resolvedAt: null,
295+
resolvedInVersion: null,
296+
resolvedBy: null,
297+
ignoredAt: null,
298+
ignoredUntil: null,
299+
ignoredReason: null,
300+
ignoredByUserId: null,
301+
ignoredByUserDisplayName: null,
302+
ignoredUntilOccurrenceRate: null,
303+
ignoredUntilTotalOccurrences: null,
304+
ignoredAtOccurrenceCount: null,
305+
},
292306
};
293307
}
294308

apps/webapp/app/v3/services/alerts/deliverAlert.server.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,9 @@ export class DeliverAlertService extends BaseService {
319319

320320
break;
321321
}
322+
case "ERROR_GROUP": {
323+
break;
324+
}
322325
default: {
323326
assertNever(alert.type);
324327
}
@@ -657,6 +660,9 @@ export class DeliverAlertService extends BaseService {
657660

658661
break;
659662
}
663+
case "ERROR_GROUP": {
664+
break;
665+
}
660666
default: {
661667
assertNever(alert.type);
662668
}
@@ -913,6 +919,9 @@ export class DeliverAlertService extends BaseService {
913919
return;
914920
}
915921
}
922+
case "ERROR_GROUP": {
923+
break;
924+
}
916925
default: {
917926
assertNever(alert.type);
918927
}

apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ export class DeliverErrorGroupAlertService {
193193
await this.#postSlackMessage(integration, {
194194
channel: slackProperties.data.channelId,
195195
...message,
196-
});
196+
} as ChatPostMessageArguments);
197197
}
198198

199199
async #sendWebhook(
@@ -300,7 +300,7 @@ export class DeliverErrorGroupAlertService {
300300
payload: ErrorAlertPayload,
301301
errorLink: string,
302302
projectName: string
303-
): Pick<ChatPostMessageArguments, "text" | "blocks" | "attachments"> {
303+
): { text: string; blocks: object[]; attachments: object[] } {
304304
const label = this.#classificationLabel(payload.classification);
305305
const errorType = payload.error.errorType || "Error";
306306
const task = payload.error.taskIdentifier;

0 commit comments

Comments
 (0)