rename bucket -> unitID in UnmarshalSourceUnit

mustansir14 · mustansir14 · commit 53a91c8175c5 · 2025-12-04T12:40:15.000+05:00
diff --git a/pkg/sources/s3/s3.go b/pkg/sources/s3/s3.go
@@ -762,8 +762,8 @@ func (s *Source) UnmarshalSourceUnit(data []byte) (sources.SourceUnit, error) {
 	if err := json.Unmarshal(data, &unit); err != nil {
 		return nil, err
 	}
-	bucket, kind := unit.SourceUnitID()
-	if bucket == "" || kind != SourceUnitKindBucket {
+	unitID, kind := unit.SourceUnitID()
+	if unitID == "" || kind != SourceUnitKindBucket {
 		return nil, fmt.Errorf("not an S3SourceUnit")
 	}
 	return unit, nil

Original file line number	Diff line number	Diff line change
`@@ -762,8 +762,8 @@ func (s *Source) UnmarshalSourceUnit(data []byte) (sources.SourceUnit, error) {`
`762`	`762`	`if err := json.Unmarshal(data, &unit); err != nil {`
`763`	`763`	`return nil, err`
`764`	`764`	`}`
`765`		`- bucket, kind := unit.SourceUnitID()`
`766`		`- if bucket == "" \|\| kind != SourceUnitKindBucket {`
	`765`	`+ unitID, kind := unit.SourceUnitID()`
	`766`	`+ if unitID == "" \|\| kind != SourceUnitKindBucket {`
`767`	`767`	`return nil, fmt.Errorf("not an S3SourceUnit")`
`768`	`768`	`}`
`769`	`769`	`return unit, nil`