-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[INS-131] Add response id and response name to Postman metadata #4555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INS-131] Add response id and response name to Postman metadata #4555
Conversation
| m.FullID = response.Uid | ||
| m.ResponseID = response.Uid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
response.Uid is already being stored in m.FullID field. Could you help me understand the reason behind storing the same value in another field, i.e., m.ResponseID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the pattern that has been used all over this source. For example, see for request ID.
FulID is supposed to contain the ID for the item (whatever it may be, request, response, folder etc) while the specific fields like RequestID and ResponseID are supposed to contain IDs of these specific items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add to @mustansir14's comment, FullID isn't present in the proto definition of Postman either, and is being used internally to form the full Link to the postman item so the response ID and name doesn't actually make its way outside of the code.
Description:
The PR adds
response_idandresponse_nameto the Postman source's metadata protos and captures these fields from the response item.Checklist:
make test-community)?make lintthis requires golangci-lint)?