-
Notifications
You must be signed in to change notification settings - Fork 34
SQLite: add test scripts #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raresgoidescu
wants to merge
3
commits into
unikraft:test
Choose a base branch
from
raresgoidescu:sqlite-test
base: test
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4bf1e1a to
0f5292b
Compare
razvand
requested changes
Jul 15, 2025
Contributor
razvand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash commits to only have 3 commits.
ad6317e to
0f5ea19
Compare
0f5ea19 to
3dc2825
Compare
d5ec16d to
5db65de
Compare
Add `sqlite/` directory:
- `setup.sh`: setup `workdir/`
- `Config.uk`: app configuration
- `Makefile`: for building the app
- `Makefile.uk`: empty placeholder file required by build system
- `fc.{arm64,x86_64}.json`: Firecracker configuration
- `xen.{arm64,x86_64}.cfg`: Xen configuration
- `rootfs/`: contains an existing database, an example script and an example `root/.sqliterc`
- `README.md`: instructions
Update the top-level `setup.sh` to clone `lib-sqlite`.
Signed-off-by: Rares-Stefan Goidescu <[email protected]>
Add `scripts/` for `sqlite/`: - `defconfig/<plat>.<arch>`: default configs, used by build scripts - `build/<plat>.<arch>`: scripts for building Unikraft images - `run/<plat>.<arch>`: scripts for running Unikraft images - `README.md`: companion README with instructions Signed-off-by: Rares-Stefan Goidescu <[email protected]>
Add `scripts/test` for `sqlite/`: - `README.md`: instructions to run the tests - `common.sh`: common functions and variables for test scripts - `single.sh`: test an instance started beforehand - `wrapper.sh`: wrapper over `single.sh` that also starts an instance - `all.sh`: test all configurations Update the top-level `test.overall.sh` to include `sqlite`. Signed-off-by: Rares-Stefan Goidescu <[email protected]>
5db65de to
3d46b2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
scripts/testforsqlite/:README.md: instructions to run the testscommon.sh: common functions and variables for test scriptssingle.sh: test an instance started beforehandwrapper.sh: wrapper oversingle.shthat also starts an instanceall.sh: test all configurationsUpdate the top-level
test.overall.shto includesqlite.