qemu/9pfs: Setup 9pfs support for redis #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
reviewed
May 17, 2025
Contributor
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
You have an issue in your commit message. It says amd instead of and.
There are some Zone.Identifier files that you added by mistake.
razvand
requested changes
May 17, 2025
Contributor
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Create two separate commits. One for Redis, one for ELF Loader.
CPIO files must not be part of the repository.
Add ending newlines for files.
NDragos
changed the title
NDragos
force-pushed
the
scripts
branch
6 times, most recently
from
2c7439b to
5de4209
Compare
Signed-off-by: Neagu Dragos-Ionut <[email protected]>
Signed-off-by: Neagu Dragos-Ionut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, the scripts for the redis work without a problem. The only problem is the elfloader. Error regarding the stack, especially the execve() system call.