Skip to content

Cannot enter tax rate with decimal values (comma or dot); validation errors not localized #4014

@thochoertler

Description

@thochoertler

It is not possible to enter a tax rate with a decimal value in the new Dashboard.
When entering a value like 5.5, saving the entry triggers the validation error "Enter a valid value", even though this is a valid number.
When using the German locale format 5,5, the form shows the error **"Expected number, received nan"`.
Both error messages are not translated, although the user language is set to German.

To Reproduce

  1. Set the Admin UI language to German.

  2. Navigate to Settings → Tax Categories or any other place where a tax rate can be entered.

  3. Create or edit a tax rate.

  4. Enter a decimal number:

    • 5.5
    • 5,5
  5. Attempt to save the tax rate.

  6. Observe the validation errors.

Expected behavior

  • Decimal values should be accepted according to the current locale:

    • English locale: 5.5
    • German locale: 5,5
  • The Admin UI should correctly parse and store decimal tax rates.

  • Validation should not incorrectly fail.

  • Error messages should be localized based on the user’s selected language.

Actual behavior

  • Input 5.5 → Error: "Enter a valid value" (not translated).
  • Input 5,5 → Error: "Expected number, received nan" (also not translated).
  • Saving the tax rate is not possible.

Screenshots/Videos

Screen.Recording.2025-12-02.at.07.43.26.mov

Environment (please complete the following information):

  • @vendure/core version: 3.5.1
  • Nodejs version: 22
  • Database (mysql/postgres etc): postgres
  • Operating System (Windows/macOS/Linux): MacOS
  • Browser (if applicable): Safari 26.1
  • Package manager (npm/yarn/pnpm): npm

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions