sorbet: cursor is hard to see in visual mode

[micampe]

It's difficult to see the cursor when in visual mode because Cursor uses reverse and Visual foreground is very similar to the Normal background.

I worked around this by setting fixed cursor colors instead of using reverse, like I've seen it's being done to solve a similar issue in MatchParen.

I'm using MacVim r179 (Vim 9.1.0)

[lifepillar]

Another option is to set a blinking cursor in Visual mode. Something like this:

set guicursor+=v:blinkwait100-blinkon400-blinkoff400

[micampe]

oh actually blinking seems to be the default, but I disabled all blinking in my gvimrc.

[neutaaaaan]

I'm not sure what could really be done here : blinking is the default behaviour of every terminal emulator I've used, and of nearly every glass tty I've seen.
The implementation can differ (reverse the cell properly or use the terminal's cursor color) but as far as I know there's little that can be done on our end that wouldn't risk overlapping in strange ways with the end user's terminal emulator settings.

[micampe]

To clarify, this is in MacVim, not in a terminal emulator (though I did disable blinking there too).

Using fixed colors for the cursor, like other themes in this repository do, seems to fix the problem, not sure if it introduces other regressions.

I'm not pushing for this to be changed, I am fine with keeping my workaround if this is determined to be an appropriate default. I have other small adjustments I apply to this and other schemes, I just thought this one was worth reporting.

I did notice while testing that quiet behaves the same.

[neutaaaaan]

I did notice while testing that quiet behaves the same.

My colorschemes are in effect built on top of quiet. and to an extent this might be a side effect of quiet's original focus on surviving borked environments against all odds, let alone sanity.

I see retrobox and zaibatsu use a fixed cursor color and don't use reverse for visual selections. I'll try and look into this next weekend.