Skip to content

Commit 442d530

Browse files
committed
fix: moved global logger error to non overwritable part of code
1 parent 0109f6b commit 442d530

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/middleware/src/errors/defaultErrorHandler.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import type { Request, Response } from "express";
2-
import { getLogger } from "../logger";
32
import { getAgnosticStatusCode } from "../helpers";
43

54
type ClientSideError = {
@@ -18,8 +17,6 @@ export const defaultErrorHandler = (
1817
req: Request,
1918
res: Response
2019
) => {
21-
const logger = getLogger(res);
22-
logger.error(error);
2320
const status = getAgnosticStatusCode(error);
2421
res.status(status);
2522
if (status < 500) {

packages/middleware/src/handlers/callApiFunction/index.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import type { Request, Response } from "express";
2+
import { getLogger } from "../../logger";
23

34
export async function callApiFunction(req: Request, res: Response) {
45
const { apiFunction, args, errorHandler } = res.locals;
@@ -7,6 +8,8 @@ export async function callApiFunction(req: Request, res: Response) {
78
const platformResponse = await apiFunction(...args);
89
res.send(platformResponse);
910
} catch (error) {
11+
const logger = getLogger(res);
12+
logger.error(error);
1013
errorHandler(error, req, res);
1114
}
1215
}

0 commit comments

Comments
 (0)