From 54bb2c2caf7134565bced109569ff421a08b3319 Mon Sep 17 00:00:00 2001 From: Reda Chouk Date: Fri, 8 May 2026 14:46:44 +0200 Subject: [PATCH] zero-initialize DecodedCert immediately after allocation in wolfssl_certmanagerloadcabuffertype to prevent cleanup on an uninitialized struct on the pem error path. --- src/ssl_certman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ssl_certman.c b/src/ssl_certman.c index e4bad5400b8..fea526e5ef7 100644 --- a/src/ssl_certman.c +++ b/src/ssl_certman.c @@ -633,6 +633,7 @@ int wolfSSL_CertManagerLoadCABufferType(WOLFSSL_CERT_MANAGER* cm, if (dCert == NULL) { ret = WOLFSSL_FATAL_ERROR; } else { + XMEMSET(dCert, 0, sizeof(DecodedCert)); if (format == WOLFSSL_FILETYPE_PEM) { #ifndef WOLFSSL_PEM_TO_DER ret = NOT_COMPILED_IN; @@ -651,7 +652,6 @@ int wolfSSL_CertManagerLoadCABufferType(WOLFSSL_CERT_MANAGER* cm, } if (ret == WOLFSSL_SUCCESS) { - XMEMSET(dCert, 0, sizeof(DecodedCert)); wc_InitDecodedCert(dCert, buff, (word32)sz, cm->heap); ret = wc_ParseCert(dCert, CERT_TYPE, NO_VERIFY, NULL);