-
Notifications
You must be signed in to change notification settings - Fork 25
Load the second half of the database on demand for GPU version #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkales
wants to merge
49
commits into
main
Choose a base branch
from
dk/load_half_on_demand
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsippl
reviewed
Apr 24, 2025
philsippl
reviewed
Apr 24, 2025
philsippl
reviewed
Apr 24, 2025
philsippl
reviewed
Apr 24, 2025
Collaborator
Author
|
Have now addressed most of the comments here, should be good for staging now @philsippl |
Contributor
|
looking great! @danielle-tfh could you give this a try on staging? |
1f0b4ae to
854415f
Compare
0bd23af to
7957dcd
Compare
87aca84 to
390d7ab
Compare
bed1aa2 to
9fcb09a
Compare
53b2697 to
74c0979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of functionality to load the second half (meaning left/right eye) of the DB (which is only searched based on some subset due to OR indices and partial results of first half of DB) on demand.
I have implemented a first version of the loader for the GPU E2E tests, this is actually most of the changes since we did not keep track of DB changes in these tests beforehand. As a side effect the Actor test setup now essentially has an expected view of the 3 node DBs for the parties after the test, in case this is useful.
TODOs:
Some other thoughts: