Skip to content

Conversation

@dkales
Copy link
Collaborator

@dkales dkales commented Apr 22, 2025

This is a first draft of functionality to load the second half (meaning left/right eye) of the DB (which is only searched based on some subset due to OR indices and partial results of first half of DB) on demand.
I have implemented a first version of the loader for the GPU E2E tests, this is actually most of the changes since we did not keep track of DB changes in these tests beforehand. As a side effect the Actor test setup now essentially has an expected view of the 3 node DBs for the parties after the test, in case this is useful.

TODOs:

  • Implement OnDemandLoader for real DB (might need interface changes for the trait since that is most likely async and the actor impl is not)
  • Test performance implications for real DB (This is something I cannot really do nicely outside of the staging setup I guess?)

Some other thoughts:

  • The current test cases do not check that resets/reauths actually modified the database in the intended way, should this be added somehow?

@dkales dkales requested a review from philsippl April 22, 2025 14:19
@dkales dkales marked this pull request as ready for review April 22, 2025 14:57
@dkales
Copy link
Collaborator Author

dkales commented Apr 25, 2025

Have now addressed most of the comments here, should be good for staging now @philsippl

@philsippl
Copy link
Contributor

looking great! @danielle-tfh could you give this a try on staging?

@dkales dkales force-pushed the dk/load_half_on_demand branch from 1f0b4ae to 854415f Compare April 29, 2025 13:24
@danielle-tfh danielle-tfh force-pushed the dk/load_half_on_demand branch from 0bd23af to 7957dcd Compare May 4, 2025 20:45
@danielle-tfh danielle-tfh force-pushed the dk/load_half_on_demand branch from 87aca84 to 390d7ab Compare May 5, 2025 20:34
@danielle-tfh danielle-tfh force-pushed the dk/load_half_on_demand branch 2 times, most recently from bed1aa2 to 9fcb09a Compare May 12, 2025 13:14
@danielle-tfh danielle-tfh force-pushed the dk/load_half_on_demand branch from 53b2697 to 74c0979 Compare May 16, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants