Commit 6acc0fa
Address remaining 13 PR comments on Commands v3 outline
This commit addresses the remaining 13 comments (beyond the initial 30) on PR #3166.
## binding-commands-to-triggers.rst (2 comments)
- Removed "How v3 triggers compare to v2 triggers" (migration guide content)
- Added note about potential updates from allwpilib PR #8366
## advanced-topics.rst (4 comments)
- Removed "Dynamic Command Generation" section entirely
- Removed "Resource pooling and management" from Advanced Async Patterns
- Changed "Priority conflicts and circular dependencies" to just "Priority conflicts"
- Removed "Memory leaks and resource exhaustion" from Edge Cases
## command-compositions.rst (2 comments)
- Removed "How v3 compositions compare to v2 command groups" (migration guide content)
- Added detailed explanation of parallel group implementation:
- All groups (parallel/race/deadline) are parallel groups with different configs
- Parallel groups have _n_ required and _m_ optional commands
- Traditional parallel: _m_ = 0, Race: _n_ = 0, Deadline: both nonzero
## commands-and-coroutines.rst (5 comments)
- Changed "generator/yield paradigm" to "yield paradigm" (commands are void-returning)
- Removed "Comparison to v2's initialize/execute/end/isFinished pattern"
- Added compiler plugin note: checks for `yield` in while-loops only
- Added compiler plugin note: checks for unreachable code after `park()`
- Removed "Where properties should be set" from Command Properties (overlaps with creation patterns)
- Removed "How lifecycle differs from v2 commands" from Command Lifecycle
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 4cd3348 commit 6acc0fa
File tree
4 files changed
+13
-24
lines changed- source/docs/software/commandbased/commands-v3
4 files changed
+13
-24
lines changedLines changed: 1 addition & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | 17 | | |
31 | 18 | | |
32 | 19 | | |
| |||
48 | 35 | | |
49 | 36 | | |
50 | 37 | | |
51 | | - | |
52 | 38 | | |
53 | 39 | | |
54 | 40 | | |
| |||
60 | 46 | | |
61 | 47 | | |
62 | 48 | | |
63 | | - | |
| 49 | + | |
64 | 50 | | |
65 | 51 | | |
66 | 52 | | |
67 | 53 | | |
68 | | - | |
69 | 54 | | |
70 | 55 | | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
| |||
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
36 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
37 | 42 | | |
38 | 43 | | |
39 | 44 | | |
| |||
Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | | - | |
27 | 26 | | |
28 | 27 | | |
29 | 28 | | |
| |||
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
| |||
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
73 | | - | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | 79 | | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
0 commit comments