Update tslint.json (#2)

Fixes warnings

Author: ThadHouse

extension/src/apiprovider.ts

@@ -4,7 +4,7 @@ import { CustomConfigurationProvider, SourceFileConfigurationItem, SourceFileCon
 import * as vscode from "vscode";
 import { GradleConfig, BinaryFind } from "./gradleconfig";
 
-function parseLanguage(args: string[], isCpp: boolean): string {
+function parseLanguage(_: string[], isCpp: boolean): string {
   if (!isCpp) {
     return 'c11';
   }
@@ -47,15 +47,15 @@ export class ApiProvider implements CustomConfigurationProvider {
 
   public name: string = 'wpilib';
 
-  public async canProvideConfiguration(uri: vscode.Uri, token?: vscode.CancellationToken | undefined): Promise<boolean> {
+  public async canProvideConfiguration(uri: vscode.Uri, _?: vscode.CancellationToken | undefined): Promise<boolean> {
     const fileWp = vscode.workspace.getWorkspaceFolder(uri);
     if (fileWp === undefined || fileWp.index !== this.workspace.index) {
       return false;
     }
     const bins = await this.gradleConfig.findMatchingBinary([uri]);
     return bins.length !== 0;
   }
-  public async provideConfigurations(uris: vscode.Uri[], token?: vscode.CancellationToken | undefined): Promise<SourceFileConfigurationItem[]> {
+  public async provideConfigurations(uris: vscode.Uri[], _?: vscode.CancellationToken | undefined): Promise<SourceFileConfigurationItem[]> {
     const bins = await this.gradleConfig.findMatchingBinary(uris);
     const ret: SourceFileConfigurationItem[] = [];
     for (const b of bins) {

extension/src/extension.ts

@@ -5,7 +5,7 @@ import * as vscode from 'vscode';
 //import { GradleConfig } from './gradleconfig';
 import { setExtensionContext } from './persistentState';
 import { ApiProvider } from './apiprovider';
-import { CppToolsApi, CustomConfigurationProvider } from './cppapi';
+import { CppToolsApi } from './cppapi';
 
 /*
 class ShimTools implements CppToolsApi {

extension/src/gradleconfig.ts

@@ -83,17 +83,17 @@ export class GradleConfig {
 
     this.disposables.push(this.statusBar);
 
-    this.configWatcher.onDidCreate(async e => {
+    this.configWatcher.onDidCreate(async _ => {
       await this.loadConfigs();
     }, this.disposables);
 
-    this.configWatcher.onDidDelete(e => {
+    this.configWatcher.onDidDelete(_ => {
       this.statusBar.text = 'none';
       this.toolchains = [];
       this.foundFiles = [];
     }, this.disposables);
 
-    this.configWatcher.onDidChange(async e => {
+    this.configWatcher.onDidChange(async _ => {
       await this.loadConfigs();
     }, this.disposables);
   }

extension/tsconfig.json

@@ -4,20 +4,21 @@
         "target": "es6",
         "outDir": "out",
         "lib": [
-            "es6"
+            "es6",
+            "dom"
         ],
         "sourceMap": true,
         "rootDir": "src",
         /* Strict Type-Checking Option */
         "strict": true,   /* enable all strict type-checking options */
         /* Additional Checks */
-        "noUnusedLocals": true /* Report errors on unused locals. */
-        // "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
-        // "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
-        // "noUnusedParameters": true,  /* Report errors on unused parameters. */
+        "noUnusedLocals": true, /* Report errors on unused locals. */
+        "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
+        "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
+        "noUnusedParameters": true,  /* Report errors on unused parameters. */
     },
     "exclude": [
         "node_modules",
         ".vscode-test"
     ]
-}
+}

extension/tslint.json

@@ -3,13 +3,34 @@
 		"no-string-throw": true,
 		"no-unused-expression": true,
 		"no-duplicate-variable": true,
+		"no-any": true,
 		"curly": true,
 		"class-name": true,
+		"no-non-null-assertion": true,
 		"semicolon": [
 			true,
 			"always"
 		],
-		"triple-equals": true
+		"switch-default": true,
+		"no-switch-case-fall-through": true,
+		"await-promise": true,
+		"no-floating-promises": true,
+		"quotemark": [true, "single"],
+		"triple-equals": true,
+		"no-unnecessary-type-assertion": true,
+		"prefer-for-of": true,
+		"prefer-const": true,
+		"member-access": true,
+		"forin": true,
+		"no-for-in-array": true,
+		"no-use-before-declare": true,
+		"no-invalid-this": true,
+		"no-shadowed-variable": true,
+		"no-this-assignment": true,
+		"no-unsafe-any": true,
+		"no-unbound-method": true,
+		"no-var-keyword": true,
+		"eofline": true
 	},
 	"defaultSeverity": "warning"
-}
+}